Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for failing unit test badge #784

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

FrancescaSchiav
Copy link
Collaborator

Summary

Quick fix for #783

Details and comments

Badge link below was wrong

Machine Learning Unit Tests

and was replaced by:
Machine Learning Unit Tests

@CLAassistant
Copy link

CLAassistant commented Feb 29, 2024

CLA assistant check
All committers have signed the CLA.

@woodsp-ibm
Copy link
Member

woodsp-ibm commented Feb 29, 2024

I must admit that I noticed this the other week, but it looked just like the other application repos we have and they were all indicating passing ok. But I see nature is failing nightly CI and it still shows tests are passing - so maybe the other repos were all "stuck" showing passing and here it was stuck showing failed. Using the same format on nature returns failing at present - which should be the true status there. The way it was done I recall it working - but it seems that's the case no longer.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8099765037

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.636%

Totals Coverage Status
Change from base Build 8099316240: 0.0%
Covered Lines: 1887
Relevant Lines: 2037

💛 - Coveralls

@OkuyanBoga
Copy link
Collaborator

I must admit that I noticed this the other week, but it looked just like the other application repos we have and they were all indicating passing ok. But I see nature is failing nightly CI and it still shows tests are passing - so maybe the other repos were all "stuck" showing passing and here it was stuck showing failed. Using the same format on nature returns failing at present - which should be the true status there. The way it was done I recall it working - but it seems that's the case no longer.

Is this something automated? Because when I check the settings of the Github Actions/Machine Learning Unit Tests, it only allows you to copy the current status, and we thought it needs to be changed in the README.md manually by simply pasting the link.

@woodsp-ibm
Copy link
Member

Is this something automated?

The link is supposed to reflect what the state is for rendering as a status badge. Take the release there in that ribbon bar you see, thats updated, the coverage etc. So its automated in that sense yes. You can copy the url into the browser and see the image, change it to nature and you will see it shows CI failing (the readme there is like it is here - before this PR changes it)

@FrancescaSchiav FrancescaSchiav merged commit 60f2c2e into qiskit-community:main Mar 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants