Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 #836

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

edoaltamura
Copy link
Collaborator

This update introduces support for Python 3.13, scheduled for final release on 7 October 2024.

Closes #825
Closes OkuyanBoga#45

@edoaltamura edoaltamura added the type: ci 🔧 Related to Continuous Integration workflows label Oct 3, 2024
@edoaltamura edoaltamura marked this pull request as draft October 3, 2024 13:47
@edoaltamura edoaltamura marked this pull request as ready for review October 8, 2024 08:52
@woodsp-ibm
Copy link
Member

woodsp-ibm commented Oct 11, 2024

FYI: Qiskit 1.3.0 milestone, due by November 21, 2024

@edoaltamura edoaltamura added this to the 0.9.0 milestone Oct 18, 2024
@edoaltamura edoaltamura marked this pull request as draft October 18, 2024 14:45
@edoaltamura edoaltamura marked this pull request as ready for review November 6, 2024 16:44
@edoaltamura
Copy link
Collaborator Author

Un-drafting this PR ahead of the RC expected release date of Qiskit 1.3 (7 Nov 2024). The due date for the official release remains 21 Nov, which is when we expect to sync Python 3.13 support for Qiskit ML too.

@edoaltamura edoaltamura modified the milestones: 0.9.0, 0.8.1 Nov 11, 2024
@edoaltamura edoaltamura added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Nov 12, 2024
@edoaltamura
Copy link
Collaborator Author

This PR has to be put on hold until #863 is resolved.

@edoaltamura edoaltamura added the on hold 🛑 Can not fix yet label Dec 2, 2024
@edoaltamura edoaltamura removed the on hold 🛑 Can not fix yet label Dec 16, 2024
@edoaltamura
Copy link
Collaborator Author

It appears there's a problem with numba when installing with Python 3.13.

Downloading numba-0.60.0.tar.gz (2.7 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.7/2.7 MB 94.5 MB/s eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [24 lines of output]
      Traceback (most recent call last):
        File "/opt/hostedtoolcache/Python/3.13.1/x[64](https://github.com/qiskit-community/qiskit-machine-learning/actions/runs/12356759451/job/34483569100?pr=836#step:5:66)/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
          ~~~~^^
        File "/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ~~~~^^^^^^^^^^^^^^^^^^^^^^^^
        File "/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-qc287bj9/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 334, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
                 ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-qc287bj9/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 304, in _get_build_requires
          self.run_setup()
          ~~~~~~~~~~~~~~^^
        File "/tmp/pip-build-env-qc287bj9/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 522, in run_setup
          super().run_setup(setup_script=setup_script)
          ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-qc287bj9/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 320, in run_setup
          exec(code, locals())
          ~~~~^^^^^^^^^^^^^^^^
        File "<string>", line 51, in <module>
        File "<string>", line 48, in _guard_py_ver
      RuntimeError: Cannot install on Python version 3.13.1; only versions >=3.9,<3.13 are supported.
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.
Error: Process completed with exit code 1.

@edoaltamura
Copy link
Collaborator Author

This is the issue with Numba: numba/numba#9413 (comment)

Ref numba/numba#9413
Ref numba/llvmlite#1084

@edoaltamura edoaltamura modified the milestones: v.0.8.2, v.0.8.3 Dec 20, 2024
@edoaltamura edoaltamura added the on hold 🛑 Can not fix yet label Dec 20, 2024
@edoaltamura edoaltamura self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold 🛑 Can not fix yet stable backport potential The bug might be minimal and/or import enough to be port to stable type: ci 🔧 Related to Continuous Integration workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI tests for py3.13 after final release #825 Add CI tests for py3.13 after final release
2 participants