Reducing numpy version for deploy-docs.yml to fix numpy 2.0 bug #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OkuyanBoga
requested review from
woodsp-ibm,
adekusar-drl,
smens,
edoaltamura,
oscar-wallis and
Benjamin-Symons
as code owners
|
That may work. I had also noted this, in a Slack conversation, in regards the torchvision pinning there ( a couple of lines above this addition) From what I can see that pin was added over 3 years ago by this #145
Maybe we should remove that version pinning. Elsewhere where it builds the html for CI it just plain installs torchvision and that seems to work i.e. it runs/builds the notebooks/html. I see you did this direct to stable 0.8. I guess whatever is done here should be done in the in main branch too so that the next stable build done off main this will work there too. But for now I guess this is the most expedient path to ensuring it works on stable |
Pull Request Test Coverage Report for Build 11825280035Details
💛 - Coveralls |
oscar-wallis
approved these changes
Nov 13, 2024
oscar-wallis
deleted the
Fix-numpy-torch-version-issue-for-deploy-docs.yml
branch
OkuyanBoga
added a commit
that referenced
this pull request
Nov 18, 2024
edoaltamura
added a commit
that referenced
this pull request
Nov 18, 2024
* Reducing numpy version for deploy-docs.yml to fix numpy 2.0 bug (#851) * Update deploy-docs.yml (#853) - Updated Python version from 3.9 to 3.10. - Removed version constraint on torchvision. - Removed Numpy version constraint. * Update deploy-docs.yml to '3.10' (#854) --------- Co-authored-by: M. Emre Sahin <40424147+OkuyanBoga@users.noreply.github.com> Co-authored-by: Oscar <108736468+oscar-wallis@users.noreply.github.com>
OkuyanBoga
added a commit
that referenced
this pull request
Dec 9, 2024
* Fix StackOverflow formatting typo in `README.md` (#847) * Fix StackOverflow formatting typo * Bump numpy version to 2 * Post release 0.8 (#844) * Change version and activate stable tutorial tests * Bump VERSION.txt * Cleanup and bugfix to support different primitives. (#55) (#855) * Cleanup and bugfix for different primitives support (#55) * Quick fix and lint for unit tests. * Fixed a bug in ComputeUncompute and lint corrections. * Fix formatting for algorithm tests * Reformatting some variables to make lint compliant. * Refactor: Cleanup code, preserve existing formatting, apply minor bug fixes, and update missing documentation * Removing unsupported classes. * Fix for lint * Fix lint errors uncovered during workflow checks * Adjust a unit test to accomodate noise-related variations * Docs 0p8 clean (#857) * Reducing numpy version for deploy-docs.yml to fix numpy 2.0 bug (#851) * Update deploy-docs.yml (#853) - Updated Python version from 3.9 to 3.10. - Removed version constraint on torchvision. - Removed Numpy version constraint. * Update deploy-docs.yml to '3.10' (#854) --------- Co-authored-by: M. Emre Sahin <40424147+OkuyanBoga@users.noreply.github.com> Co-authored-by: Oscar <108736468+oscar-wallis@users.noreply.github.com> * Remove `fastdtw` (#861) * ci(mergify): upgrade configuration to current format (#860) Co-authored-by: Mergify <37929162+mergify[bot]@users.noreply.github.com> * [Docs] Fix TOCs and update QNN derived primitives (#862) * Fix docs and update QNN derived primitives * Fix LearningRate in TOCs * Fix string formatting * Fix spelling * Fix spelling * Fix spelling * Fix copyright * Pin Qiskit to `<1.3` (#865) * Added callback function support for adam-amsgrad optimizer. (#869) * Added callback functionality to ADAM optimiser * Added unittest for callback function * Cumulative update to extend the V2 support for algorithms, updated tutorials, and partial multiclass support for VQC. (#870) * Added migration guide for 0.8 * Added V2 support for algorithms * V2 support added for unit tests of the algorithms and tutorials are updated for V2 * Spell check and lint * Update 02_migration_guide_0.8.rst * Update 02_migration_guide_0.8.rst adding optimisation level * Bugfix for V2 primitives without transpilation * Fix tutorials and release notes * Update 04_torch_qgan.ipynb * Bugfix for Qiskit 1.x register name ambiguity * Restored docs * Typo fix in gradients --------- Co-authored-by: smens <88490989+smens@users.noreply.github.com> Co-authored-by: Oscar <108736468+oscar-wallis@users.noreply.github.com> * Add predict_proba Support to PegasosQSVC and NeuralNetworkClassifier (#871) * Adding a predict_proba function to classifiers. (#57) * Update README.md * Predict proba for NNC and PegQSVC * Rewriting predict proba features and docstring It was very inefficient before and didn't have the validation checks needed. The code is now more clear and docstring has been added. * Tweak documentation for NNC and PegasosQSVC, silence lint E1101 on torch connector * Update test with `QNN.predict_proba` * Update test with `PegasosESVC.predict_proba` * Added a release note and solved conflicts with main --------- Co-authored-by: FrancescaSchiav <FrancescaSchiav@users.noreply.github.com> Co-authored-by: oscar-wallis <108736468+oscar-wallis@users.noreply.github.com> Co-authored-by: Edoardo Altamura <38359901+edoaltamura@users.noreply.github.com> Co-authored-by: smens <88490989+smens@users.noreply.github.com> * Reformatted docs * Fix usage of sklearn --------- Co-authored-by: FrancescaSchiav <FrancescaSchiav@users.noreply.github.com> Co-authored-by: oscar-wallis <108736468+oscar-wallis@users.noreply.github.com> Co-authored-by: Edoardo Altamura <38359901+edoaltamura@users.noreply.github.com> Co-authored-by: smens <88490989+smens@users.noreply.github.com> * Bump version to 0.8.1 Update version for bug-fix release --------- Co-authored-by: Edoardo Altamura <38359901+edoaltamura@users.noreply.github.com> Co-authored-by: Oscar <108736468+oscar-wallis@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: smens <88490989+smens@users.noreply.github.com> Co-authored-by: FrancescaSchiav <FrancescaSchiav@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An issue is occurring during deploying docs using the latest numpy version for pytorch. Using the latest stable version before version 2.x might temporarily sort the issue.