Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback compatibility for trainable_model (backport #878) #883

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 16, 2024

Summary

Fixed a compatibility issue as mentioned in #877 for different callback functions when it is used in trainable_model based algorithms.

Fixes #877


This is an automatic backport of pull request #878 done by [Mergify](https://mergify.com).

* Fix callback compatibility for trainable_model

* Update releasenotes/notes/fix-callback-trainable_model-ca52060260a3e466.yaml

Co-authored-by: Edoardo Altamura <38359901+edoaltamura@users.noreply.github.com>

* Update tests with callbacks

* Disable pylint unused arguments in tests

---------

Co-authored-by: Edoardo Altamura <38359901+edoaltamura@users.noreply.github.com>
(cherry picked from commit 02ee6a7)
@edoaltamura edoaltamura marked this pull request as draft December 16, 2024 19:32
@edoaltamura edoaltamura marked this pull request as ready for review December 16, 2024 19:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12359867341

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 90.711%

Files with Coverage Reduction New Missed Lines %
qiskit_machine_learning/algorithms/trainable_model.py 1 89.09%
Totals Coverage Status
Change from base Build 12356469741: 0.002%
Covered Lines: 4365
Relevant Lines: 4812

💛 - Coveralls

@edoaltamura edoaltamura merged commit 1cf2321 into stable/0.8 Dec 16, 2024
15 of 16 checks passed
@edoaltamura edoaltamura deleted the mergify/bp/stable/0.8/pr-878 branch December 16, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants