Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nick qamp 2022 #850

Merged
merged 18 commits into from
Sep 8, 2022
Merged

Nick qamp 2022 #850

merged 18 commits into from
Sep 8, 2022

Conversation

nalanzil
Copy link
Collaborator

What are the issues this pull addresses (issue numbers / links)?

This issue contains code to help (partially) address Issue 33 from Qiskit Advocate Mentorship Program (QAMP) Spring 2022: qiskit-advocate/qamp-spring-22#33

Did you add tests to cover your changes (yes/no)?

Yes, I included a demo notebook to show how the code works. Also included are two older demo/analysis notebooks on multi-qubit gates.

Did you update the documentation accordingly (yes/no)?

All documentation is included in demo notebooks.

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Four files:

  • design_check.py -> this file checks for overlap & collisions between qcomponents
  • demo notebook to show how to use design_check.py for some different qubit/CPW configurations.
  • demo notebook showing how to treat cQED using the Jaynes-Cummings formalism in metal
  • demo notebook showing how to simulate the time-dependence of a cross-resonance gate

Details and comments

Please see above.

@nalanzil nalanzil added documentation & tutorials Improvements or additions to docs and tutorials enhancement New feature or request routing & transmission lines Routing related stuff analysis: quantum labels Aug 18, 2022
@CLAassistant
Copy link

CLAassistant commented Aug 18, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@priti-ashvin-shah-ibm
Copy link
Collaborator

@ThomasGM4 , could you please review the notebooks?

qiskit_metal/qlibrary/core/design_check.py Outdated Show resolved Hide resolved
qiskit_metal/qlibrary/core/design_check.py Outdated Show resolved Hide resolved
@nalanzil nalanzil marked this pull request as ready for review September 1, 2022 18:06
Copy link
Collaborator

@ThomasGM4 ThomasGM4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick

Also noticed in the notebook "https://github.com/Qiskit/qiskit-metal/pull/850/files#diff-ae735f9012af54f827fd87991a238bea0fce4c8bee6c005413e313c0e89e1520" that have a bunch of the warning outputs. Will want to just clear outputs and save again.

qiskit_metal/qlibrary/core/design_check.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, GREAT JOB

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm merged commit 3eb215c into main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis: quantum documentation & tutorials Improvements or additions to docs and tutorials enhancement New feature or request routing & transmission lines Routing related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants