-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nick qamp 2022 #850
Nick qamp 2022 #850
Conversation
|
@ThomasGM4 , could you please review the notebooks? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick
Also noticed in the notebook "https://github.com/Qiskit/qiskit-metal/pull/850/files#diff-ae735f9012af54f827fd87991a238bea0fce4c8bee6c005413e313c0e89e1520" that have a bunch of the warning outputs. Will want to just clear outputs and save again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, GREAT JOB
What are the issues this pull addresses (issue numbers / links)?
This issue contains code to help (partially) address Issue 33 from Qiskit Advocate Mentorship Program (QAMP) Spring 2022: qiskit-advocate/qamp-spring-22#33
Did you add tests to cover your changes (yes/no)?
Yes, I included a demo notebook to show how the code works. Also included are two older demo/analysis notebooks on multi-qubit gates.
Did you update the documentation accordingly (yes/no)?
All documentation is included in demo notebooks.
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
Four files:
Details and comments
Please see above.