Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

856 more toolbox metal test cases #868

Merged
merged 27 commits into from
Nov 19, 2022
Merged

Conversation

cdelnano
Copy link
Collaborator

What are the issues this pull addresses (issue numbers / links)?

Issue #856

Did you add tests to cover your changes (yes/no)?

No

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Added unit testing for layer_stack_handler.py and bounds_for_path_and_poly_tables.py using the multiplanar design provided by @AbeerVaishnav13 .

Details and comments

@cdelnano
Copy link
Collaborator Author

Branch can be deleted after merge

@cdelnano cdelnano marked this pull request as draft October 27, 2022 17:53
@cdelnano cdelnano marked this pull request as ready for review November 8, 2022 20:28
'size_y': '7mm'
}
}
multiplanar_design.chips['c_chip'] = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is a duplicate assignment.

'size_y': '7mm'
}
}
multiplanar_design.chips['c_chip'] = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a duplicate.

coup2=dict(loc_W=1, loc_H=1)))
q1 = TransmonPocket6(multiplanar_design,
"Q1",
options=dict(**conn_pads, chip="q_chip", layer=2))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chip="c_chip", layer=1

coup2=dict(loc_W=1, loc_H=1)))
q1 = TransmonPocket6(multiplanar_design,
"Q1",
options=dict(**conn_pads, chip="q_chip", layer=2))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chip="c_chip", layer=1

coup2=dict(loc_W=1, loc_H=1)))
q1 = TransmonPocket6(multiplanar_design,
"Q1",
options=dict(**conn_pads, chip="q_chip", layer=2))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chip="c_chip", layer=1

coup2=dict(loc_W=1, loc_H=1)))
q1 = TransmonPocket6(multiplanar_design,
"Q1",
options=dict(**conn_pads, chip="q_chip", layer=2))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chip="c_chip", layer=1

coup2=dict(loc_W=1, loc_H=1)))
q1 = TransmonPocket6(multiplanar_design,
"Q1",
options=dict(**conn_pads, chip="q_chip", layer=2))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chip="c_chip", layer=1

coup2=dict(loc_W=1, loc_H=1)))
q1 = TransmonPocket6(multiplanar_design,
"Q1",
options=dict(**conn_pads, chip="q_chip", layer=2))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chip="c_chip", layer=1

coup2=dict(loc_W=1, loc_H=1)))
q1 = TransmonPocket6(multiplanar_design,
"Q1",
options=dict(**conn_pads, chip="q_chip", layer=2))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chip="c_chip", layer=1

coup2=dict(loc_W=1, loc_H=1)))
q1 = TransmonPocket6(multiplanar_design,
"Q1",
options=dict(**conn_pads, chip="q_chip", layer=2))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chip="c_chip", layer=1

coup2=dict(loc_W=1, loc_H=1)))
q1 = TransmonPocket6(multiplanar_design,
"Q1",
options=dict(**conn_pads, chip="q_chip", layer=2))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chip="c_chip", layer=1

coup2=dict(loc_W=1, loc_H=1)))
q1 = TransmonPocket6(multiplanar_design,
"Q1",
options=dict(**conn_pads, chip="q_chip", layer=2))
Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chip="c_chip", layer=1
Please search and update the rest in the module.

'size_y': '7mm'
}
}
multiplanar_design.chips['c_chip'] = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate

@cdelnano cdelnano marked this pull request as draft November 10, 2022 21:20
@cdelnano cdelnano marked this pull request as ready for review November 11, 2022 02:03
Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdelnano cdelnano merged commit 0b0c6be into main Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants