-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
856 more toolbox metal test cases #868
Conversation
…etal documentation in HTML without any errors.
… unit test to check that orient_me in about.py prints without errors.
… test get_platform_info in about.py. Which returns a string with the platform information if no errors are present.
…ispelling of exception in test_toolbox_metal_instantiation_qlibrary_gui_exception().
Branch can be deleted after merge |
…d QuadCoupler to each test case. Moved layer stack file and quadCoupler to tests/tests_data
…m/Qiskit/qiskit-metal into 856_more_toolbox_metal_test_cases
'size_y': '7mm' | ||
} | ||
} | ||
multiplanar_design.chips['c_chip'] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is a duplicate assignment.
'size_y': '7mm' | ||
} | ||
} | ||
multiplanar_design.chips['c_chip'] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a duplicate.
coup2=dict(loc_W=1, loc_H=1))) | ||
q1 = TransmonPocket6(multiplanar_design, | ||
"Q1", | ||
options=dict(**conn_pads, chip="q_chip", layer=2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chip="c_chip", layer=1
coup2=dict(loc_W=1, loc_H=1))) | ||
q1 = TransmonPocket6(multiplanar_design, | ||
"Q1", | ||
options=dict(**conn_pads, chip="q_chip", layer=2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chip="c_chip", layer=1
coup2=dict(loc_W=1, loc_H=1))) | ||
q1 = TransmonPocket6(multiplanar_design, | ||
"Q1", | ||
options=dict(**conn_pads, chip="q_chip", layer=2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chip="c_chip", layer=1
coup2=dict(loc_W=1, loc_H=1))) | ||
q1 = TransmonPocket6(multiplanar_design, | ||
"Q1", | ||
options=dict(**conn_pads, chip="q_chip", layer=2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chip="c_chip", layer=1
coup2=dict(loc_W=1, loc_H=1))) | ||
q1 = TransmonPocket6(multiplanar_design, | ||
"Q1", | ||
options=dict(**conn_pads, chip="q_chip", layer=2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chip="c_chip", layer=1
coup2=dict(loc_W=1, loc_H=1))) | ||
q1 = TransmonPocket6(multiplanar_design, | ||
"Q1", | ||
options=dict(**conn_pads, chip="q_chip", layer=2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chip="c_chip", layer=1
coup2=dict(loc_W=1, loc_H=1))) | ||
q1 = TransmonPocket6(multiplanar_design, | ||
"Q1", | ||
options=dict(**conn_pads, chip="q_chip", layer=2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chip="c_chip", layer=1
coup2=dict(loc_W=1, loc_H=1))) | ||
q1 = TransmonPocket6(multiplanar_design, | ||
"Q1", | ||
options=dict(**conn_pads, chip="q_chip", layer=2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chip="c_chip", layer=1
coup2=dict(loc_W=1, loc_H=1))) | ||
q1 = TransmonPocket6(multiplanar_design, | ||
"Q1", | ||
options=dict(**conn_pads, chip="q_chip", layer=2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chip="c_chip", layer=1
coup2=dict(loc_W=1, loc_H=1))) | ||
q1 = TransmonPocket6(multiplanar_design, | ||
"Q1", | ||
options=dict(**conn_pads, chip="q_chip", layer=2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chip="c_chip", layer=1
Please search and update the rest in the module.
'size_y': '7mm' | ||
} | ||
} | ||
multiplanar_design.chips['c_chip'] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate
…of_path_and_poly_tables
…m/Qiskit/qiskit-metal into 856_more_toolbox_metal_test_cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What are the issues this pull addresses (issue numbers / links)?
Issue #856
Did you add tests to cover your changes (yes/no)?
No
Did you update the documentation accordingly (yes/no)?
Yes
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
Added unit testing for layer_stack_handler.py and bounds_for_path_and_poly_tables.py using the multiplanar design provided by @AbeerVaishnav13 .
Details and comments