-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GaussianForcesDriver.from_molecule
improvements
#400
Comments
Hi, I am new to the contribution, I think this is a good place to start. Can I try to solve this? |
Hi @bharath1996-hub! Sure thing, please go ahead 🙂 Please make sure to apply your changes to the class in the |
@bharath1996-hub Are you still interested in working on this? Just a heads-up: #701 outlines the new direction which we are taking with Qiskit Nature which likely means that the drivers as they exist today will not be relevant in some future. It is hard to predict now in what form they will remain but if you still want to add this contribution to Qiskit Nature you are more than welcome to do so! Just let me know 👍 |
created pr at #877 |
* fix GaussianForcesDriver.from_molecule improvements #400 * remove spaces * added release note * update unittest * black reformat codes * revert this legacy file changes * reorder arguments * updated based on comments * removed unused "type: ignore" * remove white spaces * fix ci/cd error * fix lint * fix lint * test: make GaussianForcesDriver XCF test functional * Plug expected gaussian results in unit test Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> Co-authored-by: Manoel Marques <manoel.marques@ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
can close this ticket |
(qiskit-community#877) * fix GaussianForcesDriver.from_molecule improvements qiskit-community#400 * remove spaces * added release note * update unittest * black reformat codes * revert this legacy file changes * reorder arguments * updated based on comments * removed unused "type: ignore" * remove white spaces * fix ci/cd error * fix lint * fix lint * test: make GaussianForcesDriver XCF test functional * Plug expected gaussian results in unit test Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> Co-authored-by: Manoel Marques <manoel.marques@ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
What is the expected enhancement?
The
GaussianForcesDriver.from_molecule
method currently has two limitations:B3LYP
functional which should really be a configurable option.driver_kwargs
(which needs to be changed if the above functional should be made configurable in an easy fashion)On another note: technically it would be possible to use the
VibrationalStructureMoleculeDriver
wrapper to construct aGaussianForcesDriver
from a molecule while also providing alogfile
via the kwarg dict (once this gets no longer ignored). While it may seem like there is no point in doing that, it would allow for a more streamlined approach when running Gaussian calculations on another machine but using the same interface. I.e.:Machine A:
Machine B:
Instead one currently needs to use the
GaussianlogDriver
directly on machine B.If this were to be changed, the
GaussianForcesDriver
would need to relax it'scheck_installed
method when reading from alogfile
(in which case Gaussian does not need to be installed)Summary
There are three tasks:
GaussianForcesDriver
configurabledriver_kwargs
inGaussianForcesDriver.from_molecule
methodGaussianForcesDriver.check_installed
method in case of usinglogfile
The text was updated successfully, but these errors were encountered: