Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GaussianForcesDriver.from_molecule improvements #400

Closed
1 of 3 tasks
mrossinek opened this issue Oct 22, 2021 · 5 comments
Closed
1 of 3 tasks

GaussianForcesDriver.from_molecule improvements #400

mrossinek opened this issue Oct 22, 2021 · 5 comments
Labels

Comments

@mrossinek
Copy link
Member

mrossinek commented Oct 22, 2021

What is the expected enhancement?

The GaussianForcesDriver.from_molecule method currently has two limitations:

  1. It hard-codes the B3LYP functional which should really be a configurable option.
  2. It ignores driver_kwargs (which needs to be changed if the above functional should be made configurable in an easy fashion)

On another note: technically it would be possible to use the VibrationalStructureMoleculeDriver wrapper to construct a GaussianForcesDriver from a molecule while also providing a logfile via the kwarg dict (once this gets no longer ignored). While it may seem like there is no point in doing that, it would allow for a more streamlined approach when running Gaussian calculations on another machine but using the same interface. I.e.:

Machine A:

driver = VibrationalStructureMoleculeDriver(molecule, basis, driver_type)
driver.run()  # produces log written to some file

Machine B:

driver = VibrationalStructureMoleculeDriver(molecule, basis, driver_type, {"logflle": "path/to/copied/logfile.txt"})
driver.run()  # reads produced log file

Instead one currently needs to use the GaussianlogDriver directly on machine B.

If this were to be changed, the GaussianForcesDriver would need to relax it's check_installed method when reading from a logfile (in which case Gaussian does not need to be installed)

Summary

There are three tasks:

  • make XC functional in GaussianForcesDriver configurable
  • do not ignore driver_kwargs in GaussianForcesDriver.from_molecule method
  • relax GaussianForcesDriver.check_installed method in case of using logfile
@bharath1996-hub
Copy link

Hi, I am new to the contribution, I think this is a good place to start. Can I try to solve this?

@mrossinek
Copy link
Member Author

Hi @bharath1996-hub! Sure thing, please go ahead 🙂

Please make sure to apply your changes to the class in the qiskit_nature.drivers.second_quantization module (and not in qiskit_nature.drivers).

@mrossinek
Copy link
Member Author

@bharath1996-hub Are you still interested in working on this?

Just a heads-up: #701 outlines the new direction which we are taking with Qiskit Nature which likely means that the drivers as they exist today will not be relevant in some future. It is hard to predict now in what form they will remain but if you still want to add this contribution to Qiskit Nature you are more than welcome to do so! Just let me know 👍

@cometta
Copy link
Contributor

cometta commented Oct 13, 2022

created pr at #877

cometta added a commit to cometta/qiskit-nature that referenced this issue Oct 18, 2022
cometta added a commit to cometta/qiskit-nature that referenced this issue Oct 19, 2022
mergify bot added a commit that referenced this issue Oct 20, 2022
* fix GaussianForcesDriver.from_molecule improvements #400

* remove spaces

* added release note

* update unittest

* black reformat codes

* revert this legacy file changes

* reorder arguments

* updated based on comments

* removed unused "type: ignore"

* remove white spaces

* fix ci/cd error

* fix lint

* fix lint

* test: make GaussianForcesDriver XCF test functional

* Plug expected gaussian results in unit test

Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@cometta
Copy link
Contributor

cometta commented Oct 21, 2022

can close this ticket

Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this issue May 25, 2023
 (qiskit-community#877)

* fix GaussianForcesDriver.from_molecule improvements qiskit-community#400

* remove spaces

* added release note

* update unittest

* black reformat codes

* revert this legacy file changes

* reorder arguments

* updated based on comments

* removed unused "type: ignore"

* remove white spaces

* fix ci/cd error

* fix lint

* fix lint

* test: make GaussianForcesDriver XCF test functional

* Plug expected gaussian results in unit test

Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants