Add Python 3.12 support #1338
Merged
Add Python 3.12 support #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsp-ibm
added
type: ci
woodsp-ibm
requested review from
mrossinek,
robertodr and
matteoacrossi
as code owners
|
The exact 3.12.0 version made things a little more complicated around the PSI4 install. The @mrossinek I found out, after a few fails, that the reason was 3.12 was failing was due to scipy being pinned per #1214 though that gave me little context. I imagine CI was failing here too but it really just points to the Qiskit PR. Either way it needed altering to allow a newer version for 3.12, so the constraint looks like it now is in Qiskit, which still has it. Though I was wondering if it was really needed any more here - I did not try running things without it. |
mrossinek
reviewed
Feb 20, 2024
Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Pull Request Test Coverage Report for Build 7974550245Details
💛 - Coveralls |
mrossinek
approved these changes
Feb 20, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Add Python 3.12 support * Add env to pyproject * Black does not have a 312 target version * Alter PSI4 install for 3.12 as it was getting 3.12.0 * Alter PSI4 install for 3.12 as it was getting 3.12.0 * Update scipy contraint (matches qiskit again) * Update constraints.txt Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> --------- Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> (cherry picked from commit 9b9e866)
mrossinek
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Add Python 3.12 support * Add env to pyproject * Black does not have a 312 target version * Alter PSI4 install for 3.12 as it was getting 3.12.0 * Alter PSI4 install for 3.12 as it was getting 3.12.0 * Update scipy contraint (matches qiskit again) * Update constraints.txt Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> --------- Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> (cherry picked from commit 9b9e866) Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #1327 I will not mark this to close that since this still CI needs to use 3.12.0 specifically as the breaking change to testtools, referred there has not yet been addressed. So rather than have it close it and then open another specifically around juct using 3.12 when we are able, I just put a task list in there so this does one of the entries. The other will need a release of testtools first.
I marked this stable backport in order to facilitate a release that supports 3.12.
Details and comments
If/when merged will require branch rules updating.