Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoding graph attributes #338

Merged

Conversation

tommasopeduzzi
Copy link
Contributor

Summary

This patch adds custom Node and Edge classes for the attributes of the rustworkx decoding graph. It adds support for these classes everywhere, such that the tests pass.

Details and comments

@quantumjim quantumjim self-requested a review March 10, 2023 14:34
quantumjim
quantumjim previously approved these changes Mar 10, 2023
Copy link
Member

@quantumjim quantumjim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new improved version of #334. It now LGTM.

@quantumjim quantumjim self-requested a review March 14, 2023 14:04
Copy link
Member

@quantumjim quantumjim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some accidental pushes happened today, but they just made it better. It's still good to go!

@grace-harper grace-harper merged commit 886614a into qiskit-community:main Mar 14, 2023
grace-harper pushed a commit that referenced this pull request Oct 2, 2023
* make hdrg decoder more universal

* fix typos

* Add first version of Node and Edge types

Tests won't run because of circular import issue

* create CodeCircuit class

* add more detail to init

* add default is_cluster_neutral

* Add new DecodinGraph Node type support everywhere

This patch adds support for the new Node everywhere, such that it passes all tests. It also moves DecodingGraph to the analysis module due to a circular dependency issue.

* Move new Node and Edge types to utils and rename

And lint and black

* Move new Node and Edge types to utils and rename

And lint and black

* create CodeCircuit class (#329)

* create CodeCircuit class

* add more detail to init

* add default is_cluster_neutral

* Lint and Black

* Update decoding graph caching to support new node tzpes

* Added Cmake as a requirement (#336)

* element->index in decodoku

* DecodingGraph, Tests, ARC: Fix things for PR

* DecodingGraph, Tests, ARC: Fix things for PR

* remove unused import

* use all logicals

* Added Cmake as a requirement (#336) (#345)

Co-authored-by: Drew Vandeth <57962926+dsvandet@users.noreply.github.com>

* DecodingGraph: Add optional graph attribute for cached graphs

* Update hdrg_decoders.py

* Update hdrg_decoders.py

---------

Co-authored-by: James Wootton <decodoku@gmail.com>
Co-authored-by: James Wootton <jwo@zurich.ibm.com>
Co-authored-by: Drew Vandeth <57962926+dsvandet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants