-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoding graph attributes #338
Merged
grace-harper
merged 25 commits into
qiskit-community:main
from
tommasopeduzzi:decoding-graph-attributes
Mar 14, 2023
Merged
Decoding graph attributes #338
grace-harper
merged 25 commits into
qiskit-community:main
from
tommasopeduzzi:decoding-graph-attributes
Mar 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests won't run because of circular import issue
This patch adds support for the new Node everywhere, such that it passes all tests. It also moves DecodingGraph to the analysis module due to a circular dependency issue.
And lint and black
And lint and black
* create CodeCircuit class * add more detail to init * add default is_cluster_neutral
…opeduzzi/qiskit-qec into decoding-graph-attributes
quantumjim
previously approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the new improved version of #334. It now LGTM.
…#345) Co-authored-by: Drew Vandeth <57962926+dsvandet@users.noreply.github.com>
quantumjim
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some accidental pushes happened today, but they just made it better. It's still good to go!
grace-harper
pushed a commit
that referenced
this pull request
Oct 2, 2023
* make hdrg decoder more universal * fix typos * Add first version of Node and Edge types Tests won't run because of circular import issue * create CodeCircuit class * add more detail to init * add default is_cluster_neutral * Add new DecodinGraph Node type support everywhere This patch adds support for the new Node everywhere, such that it passes all tests. It also moves DecodingGraph to the analysis module due to a circular dependency issue. * Move new Node and Edge types to utils and rename And lint and black * Move new Node and Edge types to utils and rename And lint and black * create CodeCircuit class (#329) * create CodeCircuit class * add more detail to init * add default is_cluster_neutral * Lint and Black * Update decoding graph caching to support new node tzpes * Added Cmake as a requirement (#336) * element->index in decodoku * DecodingGraph, Tests, ARC: Fix things for PR * DecodingGraph, Tests, ARC: Fix things for PR * remove unused import * use all logicals * Added Cmake as a requirement (#336) (#345) Co-authored-by: Drew Vandeth <57962926+dsvandet@users.noreply.github.com> * DecodingGraph: Add optional graph attribute for cached graphs * Update hdrg_decoders.py * Update hdrg_decoders.py --------- Co-authored-by: James Wootton <decodoku@gmail.com> Co-authored-by: James Wootton <jwo@zurich.ibm.com> Co-authored-by: Drew Vandeth <57962926+dsvandet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch adds custom Node and Edge classes for the attributes of the rustworkx decoding graph. It adds support for these classes everywhere, such that the tests pass.
Details and comments