-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
352 uf for arc #362
Merged
Merged
352 uf for arc #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* some quick hacks to try to make the UnionFind Decoder run with real data. Reversal of string in process() is not needed, and qubit-index fix for the correction * fixing unittests for unionfind
grace-harper
approved these changes
May 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
grace-harper
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Small fixes to make UnionFind run with real data (#355) * some quick hacks to try to make the UnionFind Decoder run with real data. Reversal of string in process() is not needed, and qubit-index fix for the correction * fixing unittests for unionfind * prevent infinite while loop * hacky avoidance of infinite loop * fix flatten nodes * improve cluster checking for ARCs * allow check_nodes to declare non-optimal clusters as neutral * remove bug test on while loop * make everything work! * improve printing of nodes * add minimal kwarg to check_nodes * change test to linear ARC * change test to linear ARC * use rep codes to test UF * put uf into standard form * don't test things that don't work * lint and black * move cluster processing to base * make all cluster methods use standard form * restore uf test file (but streamlined) * fix inconsistencies with logical strings --------- Co-authored-by: Milan Liepelt <milan.liepelt@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #352