Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

352 uf for arc #362

Merged
merged 22 commits into from
May 5, 2023
Merged

352 uf for arc #362

merged 22 commits into from
May 5, 2023

Conversation

quantumjim
Copy link
Member

Summary

Fixes #352

@quantumjim quantumjim marked this pull request as ready for review May 2, 2023 14:38
Copy link
Collaborator

@grace-harper grace-harper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grace-harper grace-harper merged commit ada699d into main May 5, 2023
grace-harper pushed a commit that referenced this pull request Oct 2, 2023
* Small fixes to make UnionFind run with real data (#355)

* some quick hacks to try to make the UnionFind Decoder run with real data. Reversal of string in process() is not needed, and qubit-index fix for the correction

* fixing unittests for unionfind

* prevent infinite while loop

* hacky avoidance of infinite loop

* fix flatten nodes

* improve cluster checking for ARCs

* allow check_nodes to declare non-optimal clusters as neutral

* remove bug test on while loop

* make everything work!

* improve printing of nodes

* add minimal kwarg to check_nodes

* change test to linear ARC

* change test to linear ARC

* use rep codes to test UF

* put uf into standard form

* don't test things that don't work

* lint and black

* move cluster processing to base

* make all cluster methods use standard form

* restore uf test file (but streamlined)

* fix inconsistencies with logical strings

---------

Co-authored-by: Milan Liepelt <milan.liepelt@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnionFindDecoder enters infinte loop for specific real world strings
3 participants