370 speedup #371
Merged
370 speedup #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When preparing this, I noticed a TODO in the tests that annoyed me, so I fixed that too. I also noticed that a default value in |
grace-harper
pushed a commit
that referenced
this pull request
Oct 2, 2023
* use sets rather than lists * speed up check_nodes * speed up check nodes * add lower bound errors for flattened nodes * undo flattened node count * reinstate flatten nodes * expand UF tests * use higher defaulty value for 202s * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes some small changes to speed up calculations (10x increase for
get_error_probs).