Issue #247 - Replace execute with backend.run() in qiskit-qec
#381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grace-harper I have fixed #247 and it is ready for review |
robotAstray
changed the title
execute with backend.run() in qiskit-qecexecute with backend.run() in qiskit-qec
robotAstray
changed the title
execute with backend.run() in qiskit-qecexecute with backend.run() in qiskit-qec
|
Hello @grace-harper , I will look into the issues. Thank you |
|
Hello @grace-harper the test errors are related to a bug I identified and described in issue #380. I do not think is related to the work I did on issue #247. Regarding the lint/style check. I will fix those. Thank you. |
grace-harper
pushed a commit
that referenced
this pull request
Sep 19, 2023
Fix a small bug (#384) Co-authored-by: grace-harper <119029214+grace-harper@users.noreply.github.com> Update README.md (#377) Co-authored-by: grace-harper <119029214+grace-harper@users.noreply.github.com> Issue #247 - Replace `execute` with `backend.run()` in `qiskit-qec` (#381) * replace `execute` with `backend.run()` in `test_repetitionmatcher.py` * replace `execute` with `backend.run()` in `test_circuitmatcher.py` * replace `execute` with `backend.run()` in `test_heavy_hex_decoder.py` * replace `execute` with `backend.run()` in `faultsampler.py` * replace `execute` with `backend.run()` in `faultenumerator.py` * formatting * re-format test_repetitionmatcher.py --------- Co-authored-by: grace-harper <119029214+grace-harper@users.noreply.github.com> scrap
grace-harper
added a commit
that referenced
this pull request
Oct 2, 2023
…381) * replace `execute` with `backend.run()` in `test_repetitionmatcher.py` * replace `execute` with `backend.run()` in `test_circuitmatcher.py` * replace `execute` with `backend.run()` in `test_heavy_hex_decoder.py` * replace `execute` with `backend.run()` in `faultsampler.py` * replace `execute` with `backend.run()` in `faultenumerator.py` * formatting * re-format test_repetitionmatcher.py --------- Co-authored-by: grace-harper <119029214+grace-harper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request aims to resolve issue #247 by replacing the outdated
executefunction with the more up-to-datebackend.runmethod in theqiskit-qeccodebase.Details and comments:
executewithbackend.runfor simulating the quantum circuit.Additional Notes:
The following files have been modified:
test/matching/test_circuitmatcher.pytest/matching/test_repetitionmatcher.pysrc/qiskit_qec/analysis/faultsampler.pysrc/qiskit_qec/analysis/faultenumerator.pytest/heavy_hex_codes/test_heavy_hex_decoder.py