Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify matching decoding #414

Closed
wants to merge 33 commits into from
Closed

Simplify matching decoding #414

wants to merge 33 commits into from

Conversation

quantumjim
Copy link
Member

@quantumjim quantumjim commented Dec 15, 2023 •
edited
Loading

Summary

fixes #413

Removes legacy matching decoders, and replaces them with a thin layer over PyMatching.

Details and comments

  • Separates logical nodes and boundary nodes into two separate concepts.
  • Allows for two ways for the decoding graph to determine the effect on logicals: logical nodes and graphs with a fault id.
  • Introduces a lightweight matching decoder: a wrapper around PyMatching.
  • Removes old matching decoders.

@quantumjim quantumjim changed the title 413 logical nodes Simplify matching decoding Jan 18, 2024
@quantumjim quantumjim marked this pull request as ready for review January 26, 2024 17:26
grace-harper
grace-harper requested changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@grace-harper grace-harper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to check in about the pybind11. Everything else looks good. The pymatching integration is super cool.

extern/pybind11/tests/test_gil_scoped.py Outdated Show resolved Hide resolved
grace-harper
grace-harper approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@grace-harper grace-harper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quantumjim
Copy link
Member Author

Since #420 was based on this branch, that PR also covers all the changes here

@quantumjim quantumjim closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grace-harper grace-harper grace-harper approved these changes

Assignees
No one assigned
Labels
paper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify matching decoding
3 participants
@quantumjim @grace-harper @hetenyib