This repository was archived by the owner on Mar 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
New authentication #12
Merged
mtreinish
merged 15 commits into
qiskit-community:master
from
dlucchetti:new-authentication
Oct 16, 2020
Merged
New authentication #12
mtreinish
merged 15 commits into
qiskit-community:master
from
dlucchetti:new-authentication
Oct 16, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without credentials.
mtreinish
reviewed
Jul 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… number of required parameters.
…n't be run without credentials), and suppress some qiskit package warnings.
…t is not a naive datetime object.
Any additional actions/updates needed? |
mtreinish
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing this, I've been busy with a lot of different projects and this slipped through the cracks. It LGTM just an inline comment but not really a blocker.
deps = -r{toxinidir}/requirements.txt | ||
-r{toxinidir}/requirements-dev.txt | ||
keyrings.alt>=3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add this to requirement-dev.txt
instead that's normally where we put the test only requirements.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments