-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New authentication #12
New authentication #12
Conversation
…without credentials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… number of required parameters.
…n't be run without credentials), and suppress some qiskit package warnings.
…t is not a naive datetime object.
Any additional actions/updates needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing this, I've been busy with a lot of different projects and this slipped through the cracks. It LGTM just an inline comment but not really a blocker.
deps = -r{toxinidir}/requirements.txt | ||
-r{toxinidir}/requirements-dev.txt | ||
keyrings.alt>=3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add this to requirement-dev.txt
instead that's normally where we put the test only requirements.
Summary
Details and comments