Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed mapomatic dependency #117

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

nbronn
Copy link
Collaborator

@nbronn nbronn commented Aug 9, 2024

Removed mapomatic dependency for upgrade to Qiskit 1.0, now using tools from vf2_utils.py for scoring. Additionally moved to target from backend in most cases (except periodic_dynamical_decoupling and others) to conform with how properties are pulled from backends going forward.

Closes #107.
Closes #114.
Closes #115.

@coveralls
Copy link

coveralls commented Aug 9, 2024

Pull Request Test Coverage Report for Build 10373096994

Details

  • 45 of 56 (80.36%) changed or added relevant lines in 6 files are covered.
  • 15 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.6%) to 67.089%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_research/utils/convenience.py 3 5 60.0%
qiskit_research/utils/pulse_scaling.py 9 11 81.82%
qiskit_research/utils/dynamical_decoupling.py 16 23 69.57%
Files with Coverage Reduction New Missed Lines %
qiskit_research/utils/convenience.py 1 60.66%
qiskit_research/utils/dynamical_decoupling.py 1 53.82%
qiskit_research/utils/gate_decompositions.py 6 96.53%
qiskit_research/utils/gates.py 7 56.98%
Totals Coverage Status
Change from base Build 9033013756: -0.6%
Covered Lines: 636
Relevant Lines: 948

💛 - Coveralls

@nbronn nbronn requested a review from kevinsung August 13, 2024 00:58
Co-authored-by: Kevin J. Sung <kevinjefferysung@gmail.com>
@kevinsung kevinsung merged commit 0d5416a into qiskit-community:main Aug 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Qiskit 1.0 Upgrading mapomatic breaks DD tests
3 participants