-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended the gate set for pauli twirling #121
Merged
kevinsung
merged 3 commits into
qiskit-community:main
from
d-bharadwaj:add-more-twirl-gates
Oct 31, 2024
Merged
Extended the gate set for pauli twirling #121
kevinsung
merged 3 commits into
qiskit-community:main
from
d-bharadwaj:add-more-twirl-gates
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11619932235Details
💛 - Coveralls |
kevinsung
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, this is very useful!
kevinsung
requested changes
Oct 31, 2024
…for `_build_twirl_circuit`
kevinsung
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Of course! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
pauli_twirling
utility by adding support for more two-qubit gates and refactoring the code to be more modular. It also includes comprehensive tests for the newly supported gates.Enhancements to
pauli_twirling
utility:qiskit_research/utils/pauli_twirling.py
: Added support for multiple two-qubit gates by importing additional gate classes and defining corresponding gate instances.qiskit_research/utils/pauli_twirling.py
: Introduced thecreate_pauli_twirling_sets
function to dynamically generate Pauli twirling sets for any two-qubit gate, and updated theTWIRL_GATES
dictionary to use this function.Testing enhancements:
test/utils/test_pauli_twirling.py
: Added imports for the new gate classes to be tested.test/utils/test_pauli_twirling.py
: Added test cases for each newly supported two-qubit gate to verify correct implementation of Pauli twirling.Additionally, I have run the tests using tox locally and have added some more tests for the utilities introduced. Also thanks to this repo that helped me out with this. This enhancement was discussed in Issue #120, where I brought it up, and @kevinsung requested me to open a pull request.