Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended the gate set for pauli twirling #121

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

d-bharadwaj
Copy link
Contributor

This pull request enhances the pauli_twirling utility by adding support for more two-qubit gates and refactoring the code to be more modular. It also includes comprehensive tests for the newly supported gates.

Enhancements to pauli_twirling utility:

Testing enhancements:

Additionally, I have run the tests using tox locally and have added some more tests for the utilities introduced. Also thanks to this repo that helped me out with this. This enhancement was discussed in Issue #120, where I brought it up, and @kevinsung requested me to open a pull request.

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Oct 30, 2024

Pull Request Test Coverage Report for Build 11619932235

Details

  • 41 of 42 (97.62%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 68.32%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_research/utils/pauli_twirling.py 41 42 97.62%
Totals Coverage Status
Change from base Build 11055740630: 1.2%
Covered Lines: 675
Relevant Lines: 988

💛 - Coveralls

Copy link
Collaborator

@kevinsung kevinsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, this is very useful!

qiskit_research/utils/pauli_twirling.py Outdated Show resolved Hide resolved
qiskit_research/utils/pauli_twirling.py Outdated Show resolved Hide resolved
test/utils/test_pauli_twirling.py Show resolved Hide resolved
@d-bharadwaj d-bharadwaj requested a review from kevinsung October 31, 2024 04:08
qiskit_research/utils/pauli_twirling.py Outdated Show resolved Hide resolved
qiskit_research/utils/pauli_twirling.py Outdated Show resolved Hide resolved
qiskit_research/utils/pauli_twirling.py Outdated Show resolved Hide resolved
test/utils/test_pauli_twirling.py Outdated Show resolved Hide resolved
qiskit_research/utils/pauli_twirling.py Outdated Show resolved Hide resolved
qiskit_research/utils/pauli_twirling.py Outdated Show resolved Hide resolved
qiskit_research/utils/pauli_twirling.py Outdated Show resolved Hide resolved
@d-bharadwaj d-bharadwaj requested a review from kevinsung October 31, 2024 21:17
Copy link
Collaborator

@kevinsung kevinsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kevinsung kevinsung merged commit e341400 into qiskit-community:main Oct 31, 2024
11 checks passed
@d-bharadwaj
Copy link
Contributor Author

Thank you!

Of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants