Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add crzz decomposition #74

Merged
merged 2 commits into from
May 2, 2023
Merged

Conversation

kevinsung
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Apr 29, 2023

Pull Request Test Coverage Report for Build 4839384750

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 85.756%

Totals Coverage Status
Change from base Build 4774588418: 0.09%
Covered Lines: 2336
Relevant Lines: 2724

💛 - Coveralls

@kevinsung kevinsung requested a review from nbronn April 29, 2023 18:12
Copy link
Collaborator

@nbronn nbronn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only comment is why you are using theta = np.random.uniform(-10, 10) instead of

rng = np.random.default_rng()
theta = rng.uniform(-10, 10)

as in other unit tests?

@kevinsung
Copy link
Collaborator Author

LGTM! Only comment is why you are using theta = np.random.uniform(-10, 10) instead of

rng = np.random.default_rng()
theta = rng.uniform(-10, 10)

as in other unit tests?

Good catch, fixed.

Copy link
Collaborator

@nbronn nbronn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@nbronn nbronn merged commit 0deff97 into qiskit-community:main May 2, 2023
@kevinsung kevinsung deleted the crzz-decomp branch May 2, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants