Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests on Windows #30

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Enable tests on Windows #30

merged 3 commits into from
Feb 23, 2022

Conversation

garrison
Copy link
Member

@garrison garrison commented Feb 23, 2022

Summary

Details and comments

My speculation in #29 was correct. Setting shell: bash when setting up the tox environment fixes the error.

@garrison garrison marked this pull request as ready for review February 23, 2022 03:09
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, GTM

@garrison garrison merged commit d692476 into main Feb 23, 2022
@garrison garrison deleted the test-on-windows branch February 23, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants