Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade issue templates #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] Upgrade issue templates #52

wants to merge 2 commits into from

Conversation

pedrorrivero
Copy link
Member

Summary

Closes #44

Details and comments

This PR starts with simple updates to the content requested by default on issue templates.

- Update headers
- Add commented descriptions and guidelines
- Add additional context and suggestions to bug reports
- Request system information for bug reports
@pedrorrivero pedrorrivero self-assigned this Apr 18, 2022
@coveralls
Copy link

coveralls commented Apr 18, 2022

Pull Request Test Coverage Report for Build 2190451944

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2178142706: 0.0%
Covered Lines: 11
Relevant Lines: 11

💛 - Coveralls

Comment on lines 14 to 17
- Device: (e.g. MacBook Pro (16-inch, 2019))
- OS: (e.g. macOS Monterey version 12.3.1)
- Python version: (e.g. 3.8.9)
- Prototype version: (e.g. 1.0.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice if these examples were included in the HTML comment but not in the actual text. I could imagine people just submitting without modifying the text.

Also, can you think of a circumstance in which the device is relevant? It might be if they are running on POWER or Z or something, but for the most part I wouldn't expect it to be.

Copy link
Member Author

@pedrorrivero pedrorrivero Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice if these examples were included in the HTML comment but not in the actual text. I could imagine people just submitting without modifying the text.

Agree! I'll take care of it.

Also, can you think of a circumstance in which the device is relevant? It might be if they are running on POWER or Z or something, but for the most part I wouldn't expect it to be.

Yeah, I see what you mean, however I don't think there is much harm in asking, just in case. It's probably not a huge effort for the user either. What do you think?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2190451944

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2178142706: 0.0%
Covered Lines: 11
Relevant Lines: 11

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2190451944

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2178142706: 0.0%
Covered Lines: 11
Relevant Lines: 11

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Issue Templates
3 participants