-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing requirement files and setup.py with pyproject.toml #70
Merged
Merged
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
4e05afa
first attempt to add pyproject.toml
robotAstray be3b52d
tested pyproject.toml
robotAstray 5eb8fa2
remove unnecessary files
robotAstray 34ef426
add realease notes
robotAstray 9271cb3
add release notes
robotAstray 8ab08fb
additional changes to pyproject.toml
robotAstray b7327a3
Merge branch 'main' of https://github.com/robotAstray/quantum-prototy…
robotAstray 4fd0fb8
improve style in pyproject.toml
robotAstray dd99197
removing release notes
robotAstray 3301b86
Update pyproject.toml
robotAstray af5c400
minimal setup.py
robotAstray 7bc9f62
adding single trailing new line in setup.py
robotAstray 917b50a
replace requirement files on tox.ini with extras = dev
robotAstray b0d1ba2
removing the dev and min version test workflows
robotAstray 485bfaf
commenting out the paragraphs about dev and min version test workflow…
robotAstray be40dfe
added pyproject.toml description to file-map-and-description.md
robotAstray 0715093
Update tox.ini (#1)
robotAstray 3f45195
Update tox.ini
robotAstray c3a3519
Update README.md (#2)
robotAstray 304947d
Update docs/file-map-and-description.md
robotAstray a4a72f7
Fixing comment sections (#3)
robotAstray 1d4e9de
Update docs/file-map-and-description.md
robotAstray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
# file pyproject.toml | ||
|
||
[project] | ||
name = "prototype_template" | ||
dynamic = [ | ||
"version", | ||
] | ||
readme = "README.md" | ||
requires-python = ">=3.7" | ||
license = {file = "LICENSE.txt"} | ||
description = "Repository for a quantum prototype" | ||
authors = [ | ||
{ name = "My Name", email = "my.email@email.net"}, | ||
] | ||
|
||
dependencies = [ | ||
"certifi>=2021.5.30", | ||
"importlib_metadata>=4.8.1", | ||
"qiskit-aer>=0.10.3", | ||
"qiskit-terra>=0.19.2", | ||
] | ||
|
||
[project.optional-dependencies] | ||
# Dev dependencies. | ||
dev = [ | ||
"coverage>=5.5", | ||
"pylint>=2.9.5", | ||
"nbqa>=1.1.1", | ||
"treon>=0.1.3", | ||
"pytest>=6.2.5", | ||
"pytest-randomly>=1.2.0", | ||
"mypy>=0.780", | ||
"mypy-extensions>=0.4.3", | ||
"jupyter-sphinx>=0.3.2", | ||
"nbsphinx>=0.8.8", | ||
"sphinx-autodoc-typehints>=1.17.0", | ||
"reno>=3.5.0", | ||
# Black's formatting rules can change between major versions, so we use | ||
# the ~= specifier for it. | ||
"black[jupyter]~=22.1", | ||
] | ||
|
||
[project.urls] | ||
"Homepage" = "https://github.com/qiskit-community/quantum-prototype-template" | ||
"Bug Tracker" = "https://github.com/qiskit-community/quantum-prototype-template/issues" | ||
|
||
[build-system] | ||
requires = [ | ||
"setuptools>=61.0", | ||
"wheel", | ||
"toml", | ||
"setuptools-scm", | ||
] | ||
build-backend = "setuptools.build_meta" |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,7 @@ | ||
"""Setup file for prototype template.""" | ||
# See pyproject.toml for project configuration. | ||
# This file exists for compatibility with legacy tools: | ||
# https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html | ||
|
||
import setuptools | ||
from setuptools import setup | ||
|
||
with open("README.md", encoding="utf-8") as f: | ||
long_description = f.read() | ||
|
||
with open("requirements.txt") as f: | ||
install_requires = f.read().splitlines() | ||
|
||
setuptools.setup( | ||
name="prototype_template", | ||
description="Repository for a quantum prototype", | ||
long_description=long_description, | ||
long_description_content_type="text/markdown", | ||
packages=setuptools.find_packages(), | ||
install_requires=install_requires, | ||
python_requires=">=3.7", | ||
setup_requires=["setuptools_scm"], | ||
use_scm_version=True, | ||
) | ||
setup() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these lines containing
requirements.txt
andrequirements-dev.txt
? (since there is no chance in them coming back)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That has been resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double check? I think you removed a different commented region, actually, than this one in c3a3519. I was thinking it makes sense to keep the explanations in
README.md
commented out since (we hope) the development and minimum version tests will re-appear in a subsequent PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @garrison you can check my last push a4a72f7 it contains the changes you requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have also re-added the comment section I wrongly removed previously. Sorry about that.