use enum name as constant prefix #364
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I like the idea, but you |
There was a problem hiding this comment.
Please also update the tests. See the failed test run here: https://github.com/qitab/cl-protobufs/runs/7701713796?check_suite_focus=true
|
I will find a time to solve this issue |
|
I have fixed the enum-mapping-test.lisp file。 But still can`t pass all the test。 |
| @@ -292,11 +292,13 @@ message, and of +<value_name>+ when the enum is defined at top-level." | |||
| (let* ((enum-name (symbol-name type)) | |||
| (dot (position #\. enum-name :test #'char= :from-end t)) | |||
| ;; Use C/C++ enum scope. | |||
| (scope (and dot (subseq enum-name 0 dot))) | |||
| (scope enum-name | |||
| ;; (and dot (subseq enum-name 0 dot)) | |||
| @@ -81,6 +81,8 @@ and functionality for working with them." | |||
| :proto-pathname "google/protobuf/any.proto") | |||
| (:protobuf-source-file "source_context" | |||
| :proto-pathname "google/protobuf/source_context.proto") | |||
| (:protobuf-source-file "descriptor" | |||
There was a problem hiding this comment.
(not saying not to, just asking why)
There was a problem hiding this comment.
It's already there on lines 78-79.
No description provided.