Skip to content

1003 add a ruff time estimate for the overall progress#1050

Open
EinsPommes wants to merge 13 commits intomasterfrom
1003-add-a-ruff-time-estimate-for-the-overall-progress
Open

1003 add a ruff time estimate for the overall progress#1050
EinsPommes wants to merge 13 commits intomasterfrom
1003-add-a-ruff-time-estimate-for-the-overall-progress

Conversation

@EinsPommes
Copy link
Collaborator

Bild 26 12 25 um 13 07

Copilot AI review requested due to automatic review settings January 17, 2026 09:45
@EinsPommes EinsPommes linked an issue Jan 17, 2026 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a toast notification to inform users about the expected duration of the update process when they initiate an update. The notification displays immediately when the user clicks the "Apply Update" button.

Changes:

  • Added an informational toast message showing that updates take approximately 5 minutes on average

@EinsPommes EinsPommes self-assigned this Jan 17, 2026
@EinsPommes
Copy link
Collaborator Author

Could you please do a review? @Oshgnacknak

@Oshgnacknak
Copy link
Collaborator

I like it. In fact, configure the alert to be a warning that cannot be closed and states "Update in process, machine will reboot. Don't use in Production until finished", or something similar.

@TheBest6337
Copy link
Member

I would agree with @Oshgnacknak, it should also be somewhere more in the middle, because not everyone will look at the bottom right corner. I think it could fit somewhere above the percantage value, at the same height as the buttons.

@EinsPommes
Copy link
Collaborator Author

Yes, I can do that, but currently the message disappears after a few seconds. So should it be displayed permanently?
@Oshgnacknak @TheBest6337

@TheBest6337
Copy link
Member

Yes @EinsPommes

@Oshgnacknak Oshgnacknak force-pushed the 1003-add-a-ruff-time-estimate-for-the-overall-progress branch from 17901ef to 5c2beed Compare January 21, 2026 13:36
@Oshgnacknak Oshgnacknak force-pushed the 1003-add-a-ruff-time-estimate-for-the-overall-progress branch from 5c2beed to a3a343b Compare January 23, 2026 15:34
@EinsPommes
Copy link
Collaborator Author

EinsPommes commented Jan 25, 2026

Bild 25 01 26 um 17 37

That's how it looks. What do you think? @Oshgnacknak @TheBest6337

@Oshgnacknak
Copy link
Collaborator

@EinsPommes make the message permanent. You can take inspiration from the lasers warning about the diameter not being in spec.

@EinsPommes
Copy link
Collaborator Author

Okay, what about the update information, because it actually says the same thing there. @Oshgnacknak

@EinsPommes
Copy link
Collaborator Author

Bild 25 01 26 um 19 47 I have now done it this way

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@TheBest6337
Copy link
Member

You are telling the user the same thing in 2 seperate tiles. First it tells you the estimate on the right and then also in the bug update info tile.

EinsPommes and others added 2 commits February 4, 2026 08:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a ruff time estimate for the overall progress

3 participants