Conversation
Snacj
left a comment
Snacj
left a comment
There was a problem hiding this comment.
Please address the comments and see if timestamps work on actual machines.
| // Assuming the graph's fixed Y-scale is from -1 to 1 based on the sine wave example | ||
| const graphMin = -1; | ||
| const graphMax = 1; | ||
| // TODO: For real-world graphs (like Winder), you might need to read the actual min/max scale |
There was a problem hiding this comment.
We can't assume that the min/max of the y axis will always be -1 and 1.
See roundness value of the laser (min: 0, max: 100)
|
|
||
| const graphEl = graphWrapperRef.current; | ||
| // The BigGraph component is the first child (the one with the actual chart) | ||
| // TODO: Find a better way to do this |
There was a problem hiding this comment.
If there is a better way to do it, please implement. Otherwise delete the comment.
There was a problem hiding this comment.
Please test the Graph on that machine. It may not work due to the y-axis limitation.
There was a problem hiding this comment.
Please test the Graph on that machine. It may not work due to the y-axis limitation.
|
@Snacj Please finish up this Issue asap, bach's internship is over |
|
@Snacj Could you do a review? I've fixed the issues. |
TheBest6337
left a comment
TheBest6337
left a comment
There was a problem hiding this comment.
When I add an marker and move to another page or machine it isnt saved.
There was a problem hiding this comment.
Why is the size and position of the marker changing? It should rather be always at the same height in the graph window. The Text also seems to be above the value window which doesnt look right, because of the shadow it would look better if it is under it. The red line is also weird, is it an bug or a feature? It appears after adding one marker and I dont understand what it does...
|
Im also not sure if i am a fan of the many "Add Marker" buttons, we could maybe just do one button that creates an marker for the whole machine, this could just be next to the Export button for example. Then when clicked an popup opens where you can specify the time (if wanted) and add an name or color. And also if i click on the marker button i expect that the marker appears at the current live time, at the moment it comes after a few seconds. So when using the popup just always use the current time. |
|
pls submit a screenshot of a correctly placed marker, after adding about 15 I dont see a single one in my mock graphs. |
|
At the time of your message, the implementation was not yet finalized. The issue you’re referring to was already known, and I was in the process of fixing it. |
If you scroll over the names, you can see them, and that would be the latest version. @TheBest6337 |
|
@EinsPommes I would rather put them to the top and show the names all the time not only when hovering |
|
@TheBest6337 Okay, I'll do that. Currently, it only works for the mock machine. I'm working on the others. |
@TheBest6337 I have revised it. |
|
I would put it higher so it is positioned above all data and can't hide it. |
|
@TheBest6337 I am currently investigating why the marker is only rendered on test machines. |
|
@TheBest6337 Should it be possible to set the maker individually for each graph, or, for example, when you go to the extruder tab, should the maker also be set automatically for the graph temperatures and power outputs, etc.? |
|
I think the marker should only be per machine. |
|
@TheBest6337 Currently it is like this: That if you go to the extruder tab, for example, and then show you the graphs and then for example in the first graph Um, that a marker is set that in the whole extruder tab in each graph the marker is set Should this remain so? |
|
I think it's the best UX design to do it that way, but I would need to test and maybe also show some other people this feature and how they expect it to work... |
|
Okay, good. Then I'll press it now. And then you can test it. The problem is that there are still a few bugs. I would fix them. I also added a function. If you press the marker for 5 seconds, the marker will be deleted. |
…rect indentation in GraphControls
|
If you didnt know: There is a bug that only the first marker is saved, when I create another one and then go to another page I can only see the first marker when going back. Also fix the marker jumping from time to time (but you probably know this one) |
|
@TheBest6337 Yes, I was aware of that, but thank you anyway. Did he notice anything else? |
|
Only the things I told you |
5 participants
Able to add markers for timestamps and export in a new excel file. Can still improve with the code. The real scale from the Y axis of the graph is not done, right now only hard code.