Add restart backend button to DeviceEepromDialog#998
Add restart backend button to DeviceEepromDialog#998EinsPommes wants to merge 15 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the EtherCAT device assignment dialog by adding a restart backend button and implementing a touch-friendly numeric keypad for serial number input. The changes improve user workflow by allowing backend restarts directly from the dialog after device assignment.
Key Changes
- Added a restart backend button with loading states and toast notifications for user feedback
- Implemented a floating touch numpad component for serial number input with cursor controls and focus management
- Modified dialog behavior to prevent accidental closure when interacting with the numpad
TheBest6337
left a comment
TheBest6337
left a comment
There was a problem hiding this comment.
Why are there changes for the numpad? This PR should only include the restart button and nothing else.
|
Oh yes, I will fix it. |
|
What are you doing? You should only add a Restart button, not change anything else. The progress bar doesn't need an time estimate! And specifically not in this Issue. |
EinsPommes
force-pushed
the
917-add-an-restart-backend-process-button-to-ethercat-assigment
branch
2 times, most recently
from
b03a235 to
769fdb5
Compare
|
Sorry, I didn't switch branches and accidentally added the time estimate to the wrong branch (917-add-an-restart-backend-process-button-to-ethercat-assigment). This issue should only include the restart button. The branch is now cleaned up and only contains the restart button changes. The time estimate belongs in a separate issue/branch. Sorry for the confusion. |
kraemr
force-pushed
the
917-add-an-restart-backend-process-button-to-ethercat-assigment
branch
from
7f1244b to
5a08304
Compare
kraemr
force-pushed
the
917-add-an-restart-backend-process-button-to-ethercat-assigment
branch
from
52efdb4 to
c5f6f8c
Compare
Implemented a restart backend button in the EtherCAT device assignment dialog. The button allows users to restart the backend service directly from the dialog after assigning devices.
- Added restart backend service button to EtherCAT device assignment dialog - Button includes loading state and proper error handling - Updated alert message to clarify backend service restart requirement - Fixed typo in function name (DeviceEepromDialogContent) - Removed empty comment block
…g unused references
Oshgnacknak
force-pushed
the
917-add-an-restart-backend-process-button-to-ethercat-assigment
branch
from
634aeea to
a1ff1b8
Compare
|
UI wise this looks fine, ignoring that there are two write buttons. UX is bad. Restart does not save, saving hides the restart button without telling the user. Also, I managed to unassign the winder, after with I had to do some janky power-off thinks to get the terminals back into the ui and reset what I have just done |
…to-ethercat-assigment
|
I like the code much more now. What still bothers me, is how often the "have to restart" and "goto troubleshoot" are repeated. I did not look into the UI or test UX however. Therefore, this might still be fine. |
|
I tested it on my laptop, and I could test it on a machine on Saturday to see if the error is also there. @Oshgnacknak |
…to-ethercat-assigment
…to-ethercat-assigment
4 participants
Implemented a restart backend button in the EtherCAT device assignment dialog. The button allows users to restart the backend service directly from the dialog after assigning devices.