[QOLDEV-908] move WAF stack to global region #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThrawnCA
commented
Jul 8, 2024
•
ThrawnCA
commented
- WAFv2 resources are required to be in the us-east-1 region, but CloudFormation exports cannot cross regions, so use the SSM Parameter Store to pass necessary values.
- CloudFront is meant to be managed globally, and WAFv2 resources are required to be in the us-east-1 region
…ailable in the region
duttonw
reviewed
Jul 8, 2024
duttonw
requested changes
Jul 8, 2024
- Move CloudFront distribution back to the original region, but pass the Web ACL ID via SSM Parameter Store so we can cross regions
ThrawnCA
changed the title
duttonw
approved these changes
Jul 8, 2024
| CmsOrigin: "{{ CmsOrigin }}" | ||
| WebACLId: "{{ Environment }}CKANWebACLId" | ||
| WebACLId: "{{ lookup('aws_ssm', '/config/CKAN/' + Environment + '/common/waf_acl_id', region='us-east-1') }}" |
There was a problem hiding this comment.
There is a way to make this lookup on cfn template. But you do need to give different param string per env for it to work. See repo site-myqldgovau iam.cfn.yml file in the .GitHub/aws folder
There was a problem hiding this comment.
For now I would probably choose to keep the style consistent with other templates in this repo.
|
Do update the pr message per the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.