[QOLSVC-5478] gracefully handle shared emails #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
force-pushed
the
QOLSVC-5478-add-sso
branch
from
36d29cd
to
e83e3a8
Compare
- Run on all pushes, but only on PRs to master. This ensures we run tests before incorporating third party changes, without doubling up on every PR.
- If a logout path is provided, and if we have a logged-in session, then redirect to SSO and back.
duttonw
reviewed
Oct 10, 2024
duttonw
reviewed
Oct 10, 2024
ThrawnCA
force-pushed
the
QOLSVC-5478-add-sso
branch
from
bee7925
to
77a73ae
Compare
duttonw
approved these changes
Oct 11, 2024
|
should really put in unit tests, bit hard to do end to end testing with this without standing up a pkce sever to mock against. which there is actual items out there which we could put in (may need to fine a python version maybe) |
ThrawnCA
force-pushed
the
QOLSVC-5478-add-sso
branch
6 times, most recently
from
564c602
to
798e9ac
Compare
duttonw
reviewed
Oct 11, 2024
ThrawnCA
force-pushed
the
QOLSVC-5478-add-sso
branch
from
798e9ac
to
0aa7f05
Compare
ThrawnCA
force-pushed
the
QOLSVC-5478-add-sso
branch
3 times, most recently
from
dcde3f4
to
5f734f6
Compare
ThrawnCA
force-pushed
the
QOLSVC-5478-add-sso
branch
2 times, most recently
from
49afd83
to
932dd71
Compare
ThrawnCA
force-pushed
the
QOLSVC-5478-add-sso
branch
from
932dd71
to
f7c1755
Compare
duttonw
approved these changes
Oct 11, 2024
duttonw
approved these changes
Oct 11, 2024
| log.info("No SSO logout path configured, logout of [%s] will be local only", | ||
| current_user.name) | ||
| return None | ||
| session["_in_logout"] = True |
There was a problem hiding this comment.
Can you confirm that our hosting will send them back to the same server ( or refresh me that we have a Memcache shared between the 5 server instances so it will work) am a bit fuzzy on this
There was a problem hiding this comment.
Our load balancer is configured with cookie-based stickiness: https://github.com/qld-gov-au/ckan-qld-infrastructure/blob/a441ea7711b326d7d4970a59a1626ee4b017a744/templates/Datashades-OpsWorks-CKAN-Stack.cfn.yml.j2#L596
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give a nice error, instead of an ugly one, when encountering multiple accounts with the same email.