Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QOLOE-313]Video - add margin on the next element #380

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

elvishu
Copy link
Contributor

@elvishu elvishu commented Jul 19, 2024

QOLOE-313Video - add margin on the next element

This commit is to reapply the same css applied on Forgov shim into this repo.

The purpose for the code is to add spacing between video and the next element displayed after the video.

video shim file

Before After

Video - Before spacing added

Video - After spacing added

@duttonw
Copy link
Member

duttonw commented Jul 19, 2024

relates to #297

@re-becca
Copy link
Member

Looks good. One question - does it matter if other elements added below/above currently have spacing at the bottom applied (they aren't using the lobotomised owl selector)?

@elvishu elvishu merged commit 46c88f8 into develop Jul 19, 2024
5 of 7 checks passed
@elvishu elvishu deleted the QOLOE-313-Video-margin branch October 3, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants