fix: disable stylistic rules #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nilzona
commented
Nov 28, 2024
nilzona
commented
- clean up how react plugins are defined. Use their default configs as much as possible
- Remove/Disable stylistic rules conflicting with prettier
- Add prettier config to secure we don't have conflicting rules in the future.
🦋 Changeset detectedLatest commit: 1af08f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nilzona
force-pushed
the
rules-cleanup
branch
from
544e769 to
ed3e967
Compare
nilzona
commented
Nov 28, 2024
| @@ -128,7 +128,7 @@ const rules = { | |||
| "import-x/no-self-import": "error", | |||
| // Forbid cyclical dependencies between modules | |||
| // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-cycle.md | |||
| "import-x/no-cycle": ["error", { maxDepth: "∞" }], | |||
| "import-x/no-cycle": ["error", { ignoreExternal: true }], | |||
There was a problem hiding this comment.
This one increase the rule performance drastically.
egilsster
reviewed
Nov 29, 2024
egilsster
reviewed
Nov 29, 2024
egilsster
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.