This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
fix: undefined background property #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbt1
reviewed
Nov 7, 2023
src/hooks/use-load-image.js
Outdated
| @@ -11,7 +11,7 @@ const imagePromise = (url) => | |||
| }); | |||
|
|
|||
| const useLoadImage = (layout) => { | |||
| const { url } = layout.style.background; | |||
| const url = layout.style?.background?.url ?? undefined; | |||
There was a problem hiding this comment.
Don't need to do ?? undefined, but maybe you are getting a lint error?
There was a problem hiding this comment.
True, no I don't get lint error, removed it.
cbt1
approved these changes
Nov 7, 2023
qlikossbuild
pushed a commit
that referenced
this pull request
Nov 22, 2023
# [1.38.0](v1.37.1...v1.38.0) (2023-11-22) ### Bug Fixes * adding noopener to url link ([#446](#446)) ([829cde1](829cde1)) * undefined background property ([#443](#443)) ([ca91c3c](ca91c3c)) ### Features * extend gotoSheet navigation by adding chartId option ([#439](#439)) ([29e7c43](29e7c43)) * rename navigationCall parameter for chartId ([#445](#445)) ([4b3457f](4b3457f))
|
🎉 This PR is included in version 1.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes the console type error of: