feat: step cyclic dimension with sn-action-button #454
Conversation
Bjornwa
changed the title
| @@ -576,7 +576,7 @@ describe("actions", () => { | |||
| isEnabled: jest.fn().mockReturnValue(true), | |||
| }; | |||
| const result = getActionsList(shouldHide); | |||
| expect(result.length).toBe(20); | |||
| expect(result.length).toBe(21); | |||
There was a problem hiding this comment.
What does unsupported feature navigations means? Is cyclic group an unsupported feature navigation?
There was a problem hiding this comment.
This is for apps running in Direct Query mode. Unsupported features are controlled by engine and stored on the app layout. It would be good to verify if cyclic groups is something that can or cannot work in DQ apps
There was a problem hiding this comment.
Ok. Björn have noted this in our test plan. I guess in the mean time we let this test be like this until we know it has support or not
| @@ -585,7 +585,7 @@ describe("actions", () => { | |||
| isEnabled: jest.fn().mockReturnValue(true), | |||
| }; | |||
| const result = getActionsList(shouldHide); | |||
| expect(result.length).toBe(13); | |||
| expect(result.length).toBe(14); | |||
There was a problem hiding this comment.
What does feature blacklisted navigations means? is cyclic group one of the feature blacklisted navigations?
There was a problem hiding this comment.
This is also for apps running in Direct Query mode. The difference with unsupported features is that this is controlled by the client. Mostly bigger parts that just do not make sense when the app is DQ
…z/feat-cyclic-groups-action
|
Maybe some tests would be nice |
Tests added :) |
# [1.40.0](v1.39.0...v1.40.0) (2024-01-09) ### Features * step cyclic dimension with sn-action-button ([#454](#454)) ([311b679](311b679))
|
🎉 This PR is included in version 1.40.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add cyclic group action under feature flag.
Note: backend called is not working until engine release the new API.