Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

chore: make cc-test-reporter after-build do not run for forked PRs #467

Closed
wants to merge 1 commit into from

Conversation

LiKang6688
Copy link
Contributor

When there is a secret for cc-test-reporter, make it run.
reference: https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/

@niekvanstaveren
Copy link
Collaborator

What about the diff coverage? That one is required it seems

@LiKang6688
Copy link
Contributor Author

What about the diff coverage? That one is required it seems

Which line of command in the circleci do you refer to?

@niekvanstaveren
Copy link
Collaborator

What about the diff coverage? That one is required it seems

Which line of command in the circleci do you refer to?

Not sure where that is configured, but I see this
image

@LiKang6688
Copy link
Contributor Author

Right, looked into it codeclimate/test-reporter#452, it seems that the required codecliomate/diff-coverage needs cc-test-reporter.

@LiKang6688 LiKang6688 closed this Mar 3, 2022
@LiKang6688 LiKang6688 deleted the gqq/ci/forked/PRs branch April 27, 2022 21:59
@LiKang6688 LiKang6688 restored the gqq/ci/forked/PRs branch April 27, 2022 21:59
@LiKang6688 LiKang6688 deleted the gqq/ci/forked/PRs branch April 27, 2022 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants