-
Notifications
You must be signed in to change notification settings - Fork 14
chore: run yarn build to generate sn-table-ext #485
Conversation
we need this included in the package right? So we need to include the sense script somewhere where we build? |
Yes, correct. I will do that. Thanks |
d2cd382
to
98d9006
Compare
54db297
to
a8b3a7a
Compare
@Caele would be great if you can have a look so we get the bundling correct once and for all :) |
], | ||
"engines": { | ||
"node": ">=16" | ||
}, | ||
"main": "dist/sn-table.js", | ||
"module": "core/esm/index.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix error: "export 'useId' (imported as 'React') was not found in 'react'" after upgrading" (mui/material-ui#29860)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct, but it is the published output that matters.
miss sn-table-ext in the packing
https://unpkg.com/browse/@nebula.js/sn-table@1.9.0/
add
module": "core/esm/index.js"
to fix Error: "export 'useId' (imported as 'React') was not found in 'react'" after upgrading" (mui/material-ui#29860)