Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

chore: run yarn build to generate sn-table-ext #485

Merged
merged 5 commits into from
Apr 4, 2022
Merged

Conversation

LiKang6688
Copy link
Contributor

@LiKang6688 LiKang6688 commented Mar 22, 2022

miss sn-table-ext in the packing
https://unpkg.com/browse/@nebula.js/sn-table@1.9.0/

add module": "core/esm/index.js" to fix Error: "export 'useId' (imported as 'React') was not found in 'react'" after upgrading" (mui/material-ui#29860)

@haxxmaxx
Copy link
Collaborator

we need this included in the package right? So we need to include the sense script somewhere where we build?

@LiKang6688
Copy link
Contributor Author

we need this included in the package right? So we need to include the sense script somewhere where we build?

Yes, correct. I will do that. Thanks

@LiKang6688 LiKang6688 changed the title chore: use nebula sense to generate sn-table-ext chore: run yarn build to generate sn-table-ext Mar 26, 2022
@haxxmaxx
Copy link
Collaborator

haxxmaxx commented Apr 1, 2022

@Caele would be great if you can have a look so we get the bundling correct once and for all :)

],
"engines": {
"node": ">=16"
},
"main": "dist/sn-table.js",
"module": "core/esm/index.js",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix error: "export 'useId' (imported as 'React') was not found in 'react'" after upgrading" (mui/material-ui#29860)

Copy link
Collaborator

@Caele Caele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, but it is the published output that matters.

@LiKang6688 LiKang6688 merged commit b4f01b8 into main Apr 4, 2022
@LiKang6688 LiKang6688 deleted the sn-table-ext branch April 4, 2022 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants