Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkstyle plugin #1551

Merged
merged 4 commits into from
Mar 13, 2025
Merged

Add checkstyle plugin #1551

merged 4 commits into from
Mar 13, 2025

Conversation

marschattha
Copy link
Member

@marschattha marschattha commented Mar 12, 2025

One thing of note is checkfile needs a config file to run so set to suggested = "config".

In the docs example the config file in most places is just config.xml which seems to generic, so I put it as checkstyle.xml for now.

@marschattha marschattha requested a review from brynary March 12, 2025 23:01
Copy link
Contributor

qltysh bot commented Mar 12, 2025

Diff Coverage for cli: The code coverage on the diff in this pull request is 100.0%.

Total Coverage for cli: This PR will not change total coverage.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-check/src/tool/ruby/sys/macos.rs 2.6
qlty-check/src/tool/download.rs 0.7
qlty-check/src/executor/driver.rs -0.9
qlty-check/src/tool/ruby/sys/linux.rs -1.3
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Member

@brynary brynary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@marschattha marschattha merged commit d7567ac into main Mar 13, 2025
11 checks passed
@marschattha marschattha deleted the ma/add_checkstyle_plugin branch March 13, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants