Skip to content

Commit

Permalink
Skip categorisation of PR if it's only for code formatting. (#16215)
Browse files Browse the repository at this point in the history
  • Loading branch information
tzarc authored Feb 4, 2022
1 parent 0c0aa6a commit 8fd8b2d
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion lib/python/qmk/cli/generate/develop_pr_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@
clean1_expr = re.compile(r'\[(develop|keyboard|keymap|core|cli|bug|docs|feature)\]', flags=re.IGNORECASE)
clean2_expr = re.compile(r'^(develop|keyboard|keymap|core|cli|bug|docs|feature):', flags=re.IGNORECASE)

ignored_titles = ["Format code according to conventions"]


def _is_ignored(title):
for ignore in ignored_titles:
if ignore in title:
return


def _get_pr_info(cache, gh, pr_num):
pull = cache.get(f'pull:{pr_num}')
Expand Down Expand Up @@ -81,7 +89,9 @@ def fix_or_normal(info, fixes_collection, normal_collection):
else:
normal_collection.append(info)

if "dependencies" in commit_info['pr_labels']:
if _is_ignored(commit_info['title']):
return
elif "dependencies" in commit_info['pr_labels']:
fix_or_normal(commit_info, pr_list_bugs, pr_list_dependencies)
elif "core" in commit_info['pr_labels']:
fix_or_normal(commit_info, pr_list_bugs, pr_list_core)
Expand Down

0 comments on commit 8fd8b2d

Please sign in to comment.