Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ryan <fauxpark@gmail.com>
  • Loading branch information
drashna and fauxpark authored Sep 4, 2021
1 parent 3320895 commit a5ee92a
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 39 deletions.
2 changes: 0 additions & 2 deletions keyboards/sofle/keyhive/info.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
"keyboard_name": "Sofle",
"width": 16.5,
"height": 5.25,
"layouts": {
"LAYOUT": {
"layout": [
Expand Down
26 changes: 5 additions & 21 deletions keyboards/sofle/keyhive/readme.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Sofle Keyboard

![SofleKeyboard version 2.1 RGB Keyhive](https://i.imgur.com/WH9OoWu.jpg)
![SofleKeyboard version 2.1 RGB Keyhive](https://i.imgur.com/WH9OoWuh.jpg)

Sofle is 6×4+5 keys column-staggered split keyboard. Based on Lily58, Corne and Helix keyboards.

Expand Down Expand Up @@ -50,30 +50,14 @@ Build guide and log is available here: [SofleKeyboard build log/guide](https://j
- It is a good idea to Save Current Layout after you decide on your mapping.


# Compiling
Make example for this keyboard (after setting up your build environment):

Compile with the command below:
make sofle/keyhive:default

```sh
# for Elite C with Left Side Master builds
qmk compile -kb solartempest/sofle -km via
```
Flashing example for this keyboard:

## Flashing
make sofle/keyhive:default:flash

Flash using the correct command below (or use QMK Toolbox like me):

```sh
# for pro micro-based builds
qmk flash -kb solartempest/sofle -km via -bl avrdude-split-left
qmk flash -kb solartempest/sofle -km via -bl avrdude-split-right

# for Elite C or dfu bootloader builds
qmk flash -kb solartempest/sofle -km via -bl dfu-split-left
qmk flash -kb solartempest/sofle -km via -bl dfu-split-right
```

These commands can be mixed if, for example, you have an Elite C on the left and a pro micro on the right.
Press reset button on he keyboard when asked.

Disconnect the first half, connect the second one and repeat the process.
Expand Down
39 changes: 23 additions & 16 deletions keyboards/sofle/keyhive/rules.mk
Original file line number Diff line number Diff line change
@@ -1,21 +1,28 @@
# MCU name
MCU = atmega32u4


# Bootloader selection
BOOTLOADER = atmel-dfu

# Build Options
# Comment out to disable the options.

SPLIT_KEYBOARD = yes # Split keyboard
BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration
CONSOLE_ENABLE = no # Console for debug
EXTRAKEY_ENABLE = yes # Audio control and System control
RGBLIGHT_ENABLE = yes # RGB lighting
ENCODER_ENABLE = yes # Encoders
MOUSEKEY_ENABLE = no # Mouse keys
NKRO_ENABLE = yes # Enables NKRO
LTO_ENABLE = yes # Enables Link Time Optimization

OLED_ENABLE = yes # Enables OLED Display
OLED_DRIVER = SSD1306 # Specify OLED driver
WPM_ENABLE = no # WPM counter
# change yes to no to disable
#
BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite
MOUSEKEY_ENABLE = no # Mouse keys
EXTRAKEY_ENABLE = yes # Audio control and System control
CONSOLE_ENABLE = no # Console for debug
COMMAND_ENABLE = no # Commands for debug and configuration
# Do not enable SLEEP_LED_ENABLE. it uses the same timer as BACKLIGHT_ENABLE
SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend
# if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work
NKRO_ENABLE = yes # USB Nkey Rollover
BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality
RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow
BLUETOOTH_ENABLE = no # Enable Bluetooth
AUDIO_ENABLE = no # Audio output
ENCODER_ENABLE = yes
LTO_ENABLE = yes
SPLIT_KEYBOARD = yes
OLED_ENABLE = yes
OLED_DRIVER = SSD1306
WPM_ENABLE = no

0 comments on commit a5ee92a

Please sign in to comment.