Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dual RGB Matrix IS31FL3737 driver support #13442

Closed
2 of 4 tasks
ccullin opened this issue Jul 4, 2021 · 2 comments
Closed
2 of 4 tasks

Dual RGB Matrix IS31FL3737 driver support #13442

ccullin opened this issue Jul 4, 2021 · 2 comments
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.

Comments

@ccullin
Copy link

ccullin commented Jul 4, 2021 •
edited
Loading

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

Currently only a single IS31FL3737 RGB Matrix driver is supported and two are required to support a split keyboard.

I have updated code and documents below and aligned capability with other issi drivers while maintaining backward compatibility.

  • quantum/rgb_matrix_drivers.c
  • drivers/issi/is31FL3737.c
  • docs/feature_rgb_matrix.md

Before I do a pull request
Q - Should it be against development branch?
Q - Is there more I should do?
@ccullin ccullin mentioned this issue Jul 5, 2021
Merged
14 tasks
zvecr pushed a commit that referenced this issue Jul 15, 2021
@ccullin
Dual RGB Matrix IS31FL3737 driver support to address #13442 (#13457)
70267b3 
* initial commit

* removed changes to write_pwm_buffer

* backward compatbility added

* fixed issue with backward compatibility

* documentation update

* removed unneccessary comment. branched from master

* updated per comments #13457

* removed blank line

* cformat on diff files
@stale
Copy link

stale bot commented Oct 11, 2021

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 11, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this issue Dec 5, 2021
@ccullin @nhongooi
Dual RGB Matrix IS31FL3737 driver support to address qmk#13442 (qmk#1…
177240b 
…3457)

* initial commit

* removed changes to write_pwm_buffer

* backward compatbility added

* fixed issue with backward compatibility

* documentation update

* removed unneccessary comment. branched from master

* updated per comments qmk#13457

* removed blank line

* cformat on diff files
@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.

@stale stale bot closed this as completed Jan 9, 2022
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this issue May 23, 2024
@ccullin
Dual RGB Matrix IS31FL3737 driver support to address qmk#13442 (qmk#1…
72dc049 
…3457)

* initial commit

* removed changes to write_pwm_buffer

* backward compatbility added

* fixed issue with backward compatibility

* documentation update

* removed unneccessary comment. branched from master

* updated per comments qmk#13457

* removed blank line

* cformat on diff files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ccullin