Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Layer change not persistent and no startup sound when compiling using QMK (planck/rev6) #13790

Closed
jweickm opened this issue Jul 30, 2021 · 3 comments

Comments

@jweickm
Copy link

jweickm commented Jul 30, 2021

Hi fellow planckers,

I have just gotten into customizing my planck/rev6 and it has been mostly a lot of fun, although now I have hit a wall. I have already spent many frustrating hours trying to get the startup sound back and to make the layer changes persistent. With the compiled keymap that I can download from within the QMK toolbox (from qmk.fm), everything works fine. However, when compiling on my machine, even when just compiling the "default" keymap that is found under "keymaps/default" I get no startup sounds and the layer changes are not persistent through power loss.

To me, it seems that something must be wrong with the compiling environment, although there is no error message. Is the .bin file that I can download from qmk.fm directly generated based on the files in "keymaps/default" or am I missing something?

Does somebody else experience the same issue when compiling? I have tried compiling the default keymap both under windows 10 and WSL ubuntu. I have followed the install instructions to the letter. For windows 10 I used the one-click QMK MSYS installer from https://msys.qmk.fm/.

The command I used was: qmk compile -kb planck/rev6 -km default

Btw, compiling from the online configurator also resulted in me losing the startup sounds and the layer persistence.

I am grateful for any advice on how to proceed from here.
Thanks a lot,
J

Describe the Bug

  • When compiling the default keymap with QMK:
    • Layer changes not persistent
    • No startup sounds

System Information

  • Keyboard: PLANCK
    • Revision (if applicable): REV6
  • Operating system: WINDOWS 10 and WSL Ubuntu
  • AVR GCC version: 8.4.0
  • ARM GCC version: 10.1.0
  • QMK Firmware version: 0.13.28
@jweickm jweickm changed the title [Bug] Layer change not persistent and no startup sound when compiling under windows using QMK MSYS (planck/rev6) [Bug] Layer change not persistent and no startup sound when compiling using QMK (planck/rev6) Jul 30, 2021
@drashna
Copy link
Member

drashna commented Aug 9, 2021

This is a known issue, at least the audio part.
#13606

The persistent layers, are you using the set_single_persistent_default_layer function? If not, then they won't be persistent.

@jweickm
Copy link
Author

jweickm commented Aug 9, 2021

This is a known issue, at least the audio part.
#13606

The persistent layers, are you using the set_single_persistent_default_layer function? If not, then they won't be persistent.

Thank you for linking to the audio bug. I was not aware of that other issue.

Regarding the persistent layer change, I actually am using set_single_persistent_default_layer just as in the default keymap.c.
I attached my keymap.c (changed the file ending to .txt as Github does not "support" .c files) for further reference. I usually do not expect someone else to implement some feature for me, but I am really at a loss here, and would appreciate some pointers. From what I have read, my keymap.c should make layer changes persistent.
Thanks already in advance to anybody taking a look at it.
j

keymap.c.txt

@jweickm
Copy link
Author

jweickm commented Aug 9, 2021

Interestingly, I got it to work now!! Unfortunately, I cannot exactly say what solved it in the end, but I did disable

CONSOLE_ENABLE = no         # Console for debug
BOOTMAGIC_ENABLE = no      # Virtual DIP switch configuration

in the rules.mk file, which were enabled by default. It seems that the enabled bootmagic prevented the function set_single_persistent_default_layer to do its magic.
I would close this issue now, and hope that maybe some others will find this helpful.
I think that disabling BOOTMAGIC_ENABLE by default would also be a good option.

@jweickm jweickm closed this as completed Aug 9, 2021
@jweickm jweickm changed the title [Bug] Layer change not persistent and no startup sound when compiling using QMK (planck/rev6) [Bug] [Solved] Layer change not persistent and no startup sound when compiling using QMK (planck/rev6) Aug 26, 2021
@jweickm jweickm changed the title [Bug] [Solved] Layer change not persistent and no startup sound when compiling using QMK (planck/rev6) [Bug, Solved] Layer change not persistent and no startup sound when compiling using QMK (planck/rev6) Aug 26, 2021
@jweickm jweickm changed the title [Bug, Solved] Layer change not persistent and no startup sound when compiling using QMK (planck/rev6) [Bug] Layer change not persistent and no startup sound when compiling using QMK (planck/rev6) Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants