-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup Audio startup and add to documents #13606
Conversation
So the default behaviour is not the delayed startup that was added to fix stuff? |
I'm still having trouble to get the startup sound back on my preonic. In my
And in
However I don't get a startup sound, even after explicitly hitting the key for enabling sound on the keyboard after flashing. Any idea what I'm missing? |
* Fixup Audio startup and add to documents * fix doc descriptions
* Fixup Audio startup and add to documents * fix doc descriptions
Description
#11553 changed the location that the audio startup code was called (eg the code that plays the startup chime), due to issues with timing issues with the suspend code for the board and the audio.
Unfortunately, this can cause the startup sound to simply not play at all, or to play a note or two, but nothing else. Reverting the change fixes the issue, but then potentially re-introduces the previous issue.
This adds a define that allows for users to choose between which situation, until a better fix can be found.
Types of Changes
Checklist