Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup Audio startup and add to documents #13606

Merged
merged 2 commits into from
Aug 15, 2021
Merged

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 19, 2021

Description

#11553 changed the location that the audio startup code was called (eg the code that plays the startup chime), due to issues with timing issues with the suspend code for the board and the audio.

Unfortunately, this can cause the startup sound to simply not play at all, or to play a note or two, but nothing else. Reverting the change fixes the issue, but then potentially re-introduces the previous issue.

This adds a define that allows for users to choose between which situation, until a better fix can be found.

Types of Changes

  • Core
  • Bugfix
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr
Copy link
Member

zvecr commented Aug 4, 2021

Fixup Audio startup

So the default behaviour is not the delayed startup that was added to fix stuff?
Any chance the PR could be updated with a little context as to the scenario this fixes? (just so we have something to point to later)

docs/feature_audio.md Outdated Show resolved Hide resolved
@zvecr zvecr merged commit 4e3726b into qmk:develop Aug 15, 2021
@drashna drashna deleted the fixup/audio branch August 16, 2021 05:37
@sbmueller
Copy link

I'm still having trouble to get the startup sound back on my preonic. In my config.h:

#ifdef AUDIO_ENABLE
    #define STARTUP_SONG SONG(PREONIC_SOUND)
    // #define STARTUP_SONG SONG(NO_SOUND)

    #define DEFAULT_LAYER_SONGS { SONG(QWERTY_SOUND), \
                                  SONG(COLEMAK_SOUND), \
                                  SONG(DVORAK_SOUND) \
                                }
#endif

And in rules.mk:

AUDIO_ENABLE = yes

However I don't get a startup sound, even after explicitly hitting the key for enabling sound on the keyboard after flashing. Any idea what I'm missing?

nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* Fixup Audio startup and add to documents

* fix doc descriptions
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Fixup Audio startup and add to documents

* fix doc descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants