[Bug] #18643 Appears to have regressed automatic mouse layer #18970
Labels
Comments
sigprof
added a commit
to sigprof/qmk_firmware
that referenced
this issue
Nov 6, 2022
This was referenced Nov 6, 2022
zvecr
pushed a commit
that referenced
this issue
Nov 6, 2022
* Add macros to extract parameters from keycode values Implement both encoding and decoding for keycodes like TO(layer) or LM(layer, mod) in one place, so that the decoding won't get out of sync with the encoding. While at it, fix some macros for creating keycode values that did not apply the appropriate masks to parameters (and therefore could allow the result to be out of range if a wrong parameter was passed). * keymap_common: Use extraction macros for keycodes * pointing_device_auto_mouse: Use extraction macros for keycodes Fixes #18970. * process_autocorrect: Use extraction macros for keycodes * process_caps_word: Use extraction macros for keycodes (Also fix a minor bug - SH_TG was not handled properly) * process_leader: Use extraction macros for keycodes (Technically the code is not 100% correct, because it always assumes that the LT() or MT() action was a tap, but it's a separate issue that already existed before the keycode changes.) * process_unicode: Use extraction macros for keycodes * process_unicodemap: Use extraction macros for keycodes
|
@chrishoage would you mind updating |
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this issue
Nov 28, 2022
) * Add macros to extract parameters from keycode values Implement both encoding and decoding for keycodes like TO(layer) or LM(layer, mod) in one place, so that the decoding won't get out of sync with the encoding. While at it, fix some macros for creating keycode values that did not apply the appropriate masks to parameters (and therefore could allow the result to be out of range if a wrong parameter was passed). * keymap_common: Use extraction macros for keycodes * pointing_device_auto_mouse: Use extraction macros for keycodes Fixes qmk#18970. * process_autocorrect: Use extraction macros for keycodes * process_caps_word: Use extraction macros for keycodes (Also fix a minor bug - SH_TG was not handled properly) * process_leader: Use extraction macros for keycodes (Technically the code is not 100% correct, because it always assumes that the LT() or MT() action was a tap, but it's a separate issue that already existed before the keycode changes.) * process_unicode: Use extraction macros for keycodes * process_unicodemap: Use extraction macros for keycodes
elpekenin
pushed a commit
to elpekenin/qmk_firmware
that referenced
this issue
Dec 7, 2022
) * Add macros to extract parameters from keycode values Implement both encoding and decoding for keycodes like TO(layer) or LM(layer, mod) in one place, so that the decoding won't get out of sync with the encoding. While at it, fix some macros for creating keycode values that did not apply the appropriate masks to parameters (and therefore could allow the result to be out of range if a wrong parameter was passed). * keymap_common: Use extraction macros for keycodes * pointing_device_auto_mouse: Use extraction macros for keycodes Fixes qmk#18970. * process_autocorrect: Use extraction macros for keycodes * process_caps_word: Use extraction macros for keycodes (Also fix a minor bug - SH_TG was not handled properly) * process_leader: Use extraction macros for keycodes (Technically the code is not 100% correct, because it always assumes that the LT() or MT() action was a tap, but it's a separate issue that already existed before the keycode changes.) * process_unicode: Use extraction macros for keycodes * process_unicodemap: Use extraction macros for keycodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
When using
AUTO_MOUSE_DEFAULT_LAYERwhere the mouse layer is the same layer as the keymap ofMO(MOUSE_LAYER)(e.g.AUTO_MOUSE_DEFAULT_LAYER 1andMO(1)the layer is immediately lowered.I noticed I would receive two
mousekeylogs in qmk consoleWhere as on the last good commit I would only get one
mousekeylog when triggering `MO(1)I bisected back to a69ab05 and a070c4c was the last good commit.
To reproduce you seem to just need to have a MO(1) and
set_auto_mouse_layer(1);/AUTO_MOUSE_DEFAULT_LAYER 1. I rebased my work on develop and noticed this regression - I then bisected back to the working commit. I made no other changes to my codeKeyboard Used
N/A (working on firmware for a new keyboard and found this issue)
Link to product page (if applicable)
No response
Operating System
Linux
qmk doctor Output
Is AutoHotKey / Karabiner installed
Other keyboard-related software installed
No response
Additional Context
I am happy to provide my unfinished keyboard code if it is helpful to reproduce this issue.
The text was updated successfully, but these errors were encountered: