Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative path change causes compile error on paths with spaces. #403

Closed
mikelduffy opened this issue Jun 13, 2016 · 3 comments
Closed

Relative path change causes compile error on paths with spaces. #403

mikelduffy opened this issue Jun 13, 2016 · 3 comments

Comments

@mikelduffy
Copy link

mikelduffy commented Jun 13, 2016

Problem occurring on osx for paths with spaces. Compile error that I get is:

make: *** /Users/username: Is a directory. Stop.

Works after moving directory into a path without spaces.

@mikelduffy mikelduffy changed the title Relative path changes causes Relative path change causes compile error on paths with spaces. Jun 13, 2016
@jackhumbert
Copy link
Member

This is after this commit? Do you have the same problem before it?

@mikelduffy
Copy link
Author

Thanks for such a quick response, and for maintaining such an awesome firmware!

Yes, it was that commit, and no, the problem did not exist previously. I just removed the spaces from my folder hierarchy to avoid such problems in the future.

@jackhumbert
Copy link
Member

Fixed at c4ea06d!

ryaninvents pushed a commit to ryaninvents/qmk_firmware that referenced this issue Aug 12, 2016
BlueTufa pushed a commit to BlueTufa/qmk_firmware that referenced this issue Aug 6, 2021
* add support to load keymaps from url

* adding modal

* review

* CSS style the modal box (#1)

- remove min-height from .input-url-modal to not waste space
- apply full border declaration to .input-url-modal
- apply padding to .input-url-modal
- apply CSS rules to .input-url-modal's child elements
  - makes the modal's appearance more consistent with main UI
- swap positions of Load and Cancel buttons

* css fix
JAO1988 pushed a commit to JAO1988/qmk_firmware that referenced this issue Sep 25, 2024
* Add HATOR Gravity X TKL keyboard support

* fixes

copyright holder fix, config.h edited

* via and default keymap.c updates

* whitespace removed (readme.md)

* Maximum brightness returned (config.h)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants