Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter Key and \| key seem to be swapped in the matrix. Melody96 #6471

Closed
rockydbull opened this issue Aug 2, 2019 · 5 comments · Fixed by #22113
Closed

Enter Key and \| key seem to be swapped in the matrix. Melody96 #6471

rockydbull opened this issue Aug 2, 2019 · 5 comments · Fixed by #22113
Assignees

Comments

@rockydbull
Copy link

When using the qmk config website I have to move the enter key to the |\ position and the |\ key to the enter key position for them to properly work on their correct keys IRL according to the ansi standard. This is with the melody96 hotswap ansi board with the 1u bottom row.

@noroadsleft
Copy link
Member

@zunger-humu,

You added the LAYOUT_hotswap macro to the melody96. Does your keymap work as intended when compiled from a current QMK master, and do you use ANSI Enter or ISO Enter? I looked at the macros and the LAYOUT_hotswap macro doesn't assign KC_BSLS on your keymap to the same place in the matrix as the other two macros would do.

Would appreciate your insight on this.

@rockydbull
Copy link
Author

@noroadsleft I think you may have replied to the wrong user (I also might be misreading this). I didnt make a layout. I am having the flipped |\ and enter key issue on the default layout with QMK. I am using Ansi enter for reference.

@zunger-humu
Copy link
Contributor

zunger-humu commented Aug 3, 2019 via email

@noroadsleft
Copy link
Member

@zunger-humu Thanks for responding.

@rockydbull I requested zunger-humu's input because he's the user who submitted the Melody96 LAYOUT_hotswap macro to QMK, and I wanted to make sure that it was working for him. Sometimes a user will submit code and then discover it doesn't work correctly after their submission has been merged, so they fix it locally but then never submit those fixes back to us. zunger-humu has no history of doing this, but I wanted to make sure as I don't own the board in question.

Actually, looking over your initial post, @rockydbull, are you just flashing the default keymap that loads when you select melody96 as your keyboard in QMK Configurator?

@zunger-humu
Copy link
Contributor

zunger-humu commented Aug 3, 2019

I'm typing on said keyboard right now, in fact. :)

@noroadleft, that would be my next question, too; the default melody96 keymap definitely didn't work for me on the hotswap. My keymap may be a bit on the intense side (the ability to type in Greek letters and math symbols and such) but you should definitely be able to use it, or build your own with the macros added.

(Which reminds me that I had some improvements to that keymap in mind, I should do those)

(ETA: I just did those and made a PR, and in the process verified that melody96:zunger does work fine at head)

@tzarc tzarc closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants