Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add via keymap for boardsource/3x4 #10043

Merged
merged 6 commits into from
Aug 18, 2020
Merged

add via keymap for boardsource/3x4 #10043

merged 6 commits into from
Aug 18, 2020

Conversation

gwillad
Copy link
Contributor

@gwillad gwillad commented Aug 15, 2020 •
edited
Loading

Add boardsource/3x4 keymap for via support

In /keyboards/boardsource/3x4/keymaps added

  • via/
  • via/keymap.c which contains the same layout as keymaps/default/keymaps.c
  • via/rules.mk which enables via
  • via/readme.md
  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • changed boardsource/3x4 product id to be unique

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@gwillad gwillad mentioned this pull request Aug 15, 2020
Merged
6 tasks
fauxpark
fauxpark requested changes Aug 15, 2020
View reviewed changes
@fauxpark fauxpark added keymap via Adds via keymap and/or updates keyboard for via support labels Aug 15, 2020
@fauxpark fauxpark requested a review from a team August 15, 2020 05:19
@gwillad @fauxpark
Apply suggestions from code review
c1508cc 
fix rules.mk

Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
fauxpark requested changes Aug 15, 2020
View reviewed changes
@gwillad @fauxpark
Update keyboards/boardsource/3x4/rules.mk
cd1663d 
Co-authored-by: Ryan <fauxpark@gmail.com>
@fauxpark fauxpark requested a review from a team August 15, 2020 16:19
zvecr
zvecr requested changes Aug 16, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRODUCT_ID for the keyboard is not unique.

noroadsleft
noroadsleft requested changes Aug 18, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the risk of maybe throwing this for a loop, I've suggested a change to VENDOR_ID, based on tracing the original instance of 0xF7E0 to the handwired/412_64, which evolved into the standaside by FateEverywhere.

keybage/radpad uses 0x4253 // "BS", derived from the designer/vendor's initials, so I made a suggestion based on a lowercase s in Boardsource here.

edit: The idea here is that the other Boardsource keyboards will use this updated Vendor ID when they gain VIA keymaps.

@noroadsleft
Copy link
Member

noroadsleft commented Aug 18, 2020 •
edited
Loading

@gwillad,

should I take the time to change this for the other boardsource boards - others aren't currently supported by VIA, so I'm assuming this wouldn't be a breaking change?

For the other Boardsource boards, you can if you want. If not I'll try to get it in the next couple of days. EDIT: Disregard this; I'll file a new PR, as this one is ready.

happy to make this change - are product id's unique across the project? Or just across a vendor?

The Vendor/Product pairings should be unique across the project (unless it's different revisions of the same keyboard), but this is something that we haven't kept track of over the years. Ideally each keyboard by a specific designer or vendor should share a Vendor ID, each with a unique Product ID.

noroadsleft
noroadsleft approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 5aa55a7 into qmk:master Aug 18, 2020
@noroadsleft
Copy link
Member

Thanks!

@gwillad gwillad deleted the 3x4 branch August 18, 2020 22:56
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 20, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
4888f60 
* 'master' of https://github.com/qmk/qmk_firmware: (126 commits)
  [Keyboard] AJisai74 (qmk#10021)
  [Keyboard] HolySwitch Co Southpaw75 (qmk#10011)
  [Keymap] update dvorak_42_key keymaps for atreus and ergodox_ez: add VSCode shortcuts (qmk#10054)
  Fix typo in docs/feature_dynamic_macros (qmk#10085)
  [Keymap] VIA keymap for Cannonkeys Ortho60 (qmk#10086)
  [Keymap] xd60:shura30 (qmk#10089)
  Rename keyboards/handwired/zergo/keymap.c to keyboards/handwired/zergo/keymaps/default/keymap.c (qmk#10094)
  [Keymap] added dbroqua keymap for kbdfans/kbd6x (qmk#10072)
  [Keyboard] Vision keyboard by SatT (qmk#9768)
  60_ansi_arrows Community Layout; mrsendyyk keymaps for dz60 and maartenwut/eon65 (qmk#9993)
  [Keyboard] add Xelus Valor (qmk#10079)
  [Keyboard] Add support for keyboard 'Bolt' (qmk#10046)
  [Keymap] update kejadlen keymaps (qmk#9954)
  [Keymap] jotix_ortho_4x12_layout (qmk#10075)
  Changes to thevankeyboards/minivan:king keymap (qmk#10032)
  Refactor Adelais PCB (qmk#10069)
  [Keyboard] NK87 (qmk#9965)
  Update keymap for Keebio/iris4/rev4 (qmk#10062)
  Dawn60 update that breaks travis keyboard builds (qmk#10082)
  add VIA keymap for boardsource/3x4 (qmk#10043)
  ...
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@gwillad @nicocesar
add VIA keymap for boardsource/3x4 (qmk#10043)
ed3a704 
* via keymap for boardsource/3x4

* fix formatting

* Apply suggestions from code review

fix rules.mk

* Update keyboards/boardsource/3x4/rules.mk

* use unique product ID

* update vendor id to be unique, update product id to make more sense
@noroadsleft noroadsleft mentioned this pull request Sep 8, 2020
Merged
14 tasks
@gwillad gwillad mentioned this pull request Sep 13, 2020
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gwillad @noroadsleft @fauxpark @zvecr