Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budget96 info cleanup and updates #10268

Merged
merged 6 commits into from
Sep 22, 2020
Merged

Budget96 info cleanup and updates #10268

merged 6 commits into from
Sep 22, 2020

Conversation

DonutCatDev
Copy link
Contributor

Description

Updates to basic info files for Budget96 for consistency/cleanliness. Includes adding proper ID/description values for VIA or other interaction in the future.

Also includes a personal map folder.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you convert the tabs to spaces in the keymap?
You can run qmk cformat keyboards/donutcables/budget96/keymaps/donut/keymap.c to do this.

@DonutCatDev
Copy link
Contributor Author

Could you convert the tabs to spaces in the keymap?
You can run qmk cformat keyboards/donutcables/budget96/keymaps/donut/keymap.c to do this.

Accidentally bodged my rebase attempt and didn't know a reset would close the PR. Should I open a new one or can this one be pointed to the new commits?

@DonutCatDev DonutCatDev reopened this Sep 9, 2020
@DonutCatDev DonutCatDev requested a review from drashna September 13, 2020 03:27
@drashna drashna requested a review from a team September 19, 2020 23:42
keyboards/donutcables/budget96/config.h Outdated Show resolved Hide resolved
keyboards/donutcables/budget96/keymaps/donut/keymap.c Outdated Show resolved Hide resolved
keyboards/donutcables/budget96/keymaps/donut/rules.mk Outdated Show resolved Hide resolved
DonutCables and others added 3 commits September 19, 2020 23:04
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
keyboards/donutcables/budget96/config.h Outdated Show resolved Hide resolved
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna merged commit 4a37af7 into qmk:master Sep 22, 2020
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
* Cleanup/updates to Budget96 info

* Add personal keymap

* Requested config.h update

Co-authored-by: Ryan <fauxpark@gmail.com>

* Requested rules.mk update

Co-authored-by: Ryan <fauxpark@gmail.com>

* Requested keymap.c update

* Requested config.h update

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* Cleanup/updates to Budget96 info

* Add personal keymap

* Requested config.h update

Co-authored-by: Ryan <fauxpark@gmail.com>

* Requested rules.mk update

Co-authored-by: Ryan <fauxpark@gmail.com>

* Requested keymap.c update

* Requested config.h update

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants