Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the use of only one IS31FL3731 LED driver #10404

Merged
merged 2 commits into from
Oct 4, 2020
Merged

Allow the use of only one IS31FL3731 LED driver #10404

merged 2 commits into from
Oct 4, 2020

Conversation

cmdremily
Copy link
Contributor

@cmdremily cmdremily commented Sep 23, 2020 •
edited by noroadsleft
Loading

Core fixes required for OpenDeck32.

Requested split from #10305 (review)

Description

  • Allows the use of only one IS31FL3731 LED driver (instead of two)
  • Removes unused variables when RGB_MATRIX_DISABLE_KEYCODES is set, preventing a clean compile with -Werror.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • (let me know if you want me to create issues for this, I'm refraining from doing it to avoid a race with some one fixing it before this is merged).

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@cmdremily cmdremily mentioned this pull request Sep 23, 2020
Merged
14 tasks
@noroadsleft noroadsleft requested a review from drashna September 23, 2020 16:30
@noroadsleft noroadsleft changed the title Core fixes required for OpenDeck32 Allow the use of only one IS31FL3731 LED driver Sep 23, 2020
noroadsleft
noroadsleft approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@drashna drashna merged commit c4f910b into qmk:master Oct 4, 2020
@elfmimi elfmimi mentioned this pull request Oct 6, 2020
Merged
14 tasks
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@drashna
Merge pull request qmk#10404 from cmdremily/opendeck-core
cdc36f7 
Allow the use of only one IS31FL3731 LED driver
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna
Merge pull request qmk#10404 from cmdremily/opendeck-core
8040658 
Allow the use of only one IS31FL3731 LED driver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmdremily @tzarc @noroadsleft @drashna