Crkbd implementing return value for matrix_scan()

[yhr0x43]

Description

The OLED screen on the keyboard never turns off with the timeout as it supposed to.

With debugging output, it appears keyboard_task() in tmk_core/common/keyboard.c is constantly calling oled_on(). This only happens when OLED_DRIVER_ENABLE is defined and OLED_DISABLE_TIMEOUT is not defined.

It appears that the return value of matrix_scam() is interpreted as a boolean of whether there are updates. And the custom implementation of that function in crkbd returns a constant 1.

Thus I imitate the way quantum/matrix.c implement this return value and applied it to the crkbd implementation.

Despite a required change of the return type for matrix_slave_scan() from void to uint8_t, this function is never meant to and never does be called anywhere else. This change should not affect anything else.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[fauxpark]

Thanks!