Add The Railroad (rev 0) #10474
Merged
Add The Railroad (rev 0) #10474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull from master
Pull from master
|
@ridingqwerty , I've moved my keyboard changes to this PR. |
14 tasks
ridingqwerty
requested changes
Sep 28, 2020
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
|
@ridingqwerty , I think I've made all the suggested changes now. |
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
|
@ridingqwerty it's still showing that you've requested changes. Is there anything I'm still missing? |
ridingqwerty
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Looks better now @nopunin10did , I just simply haven't had a chance to re-review. That icon clears after the next review (or if you re-request one).
Gotcha. Still getting used to Github idiosyncrasies; we use a different Git provider at work. |
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
fauxpark
requested changes
Oct 2, 2020
noroadsleft
requested changes
Oct 2, 2020
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Erovia
requested changes
Oct 4, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
noroadsleft
reviewed
Oct 14, 2020
There was a problem hiding this comment.
Everything code-wise looks good to me, but a meta comment of sorts:
As this is for a prototype according to the readme, it may make sense to drop the keyboard code down a folder to revision level as keyboards/nopunin10did/railroad/rev0/. Then support for the non-prototype PCB can be added as keyboards/nopunin10did/railroad/rev1/, and the original codebase left unchanged.
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
This was a good suggestion, and I've performed that change with the latest commit. |
fauxpark
approved these changes
Oct 30, 2020
drashna
approved these changes
Nov 1, 2020
oscarcarlsson
pushed a commit
to oscarcarlsson/qmk_firmware
that referenced
this pull request
Nov 2, 2020
* Add The Railroad keyboard, rev 0 * Update keyboards/nopunin10did/railroad/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update config.h * Update keyboards/nopunin10did/railroad/rules.mk Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/nopunin10did/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/nopunin10did/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/nopunin10did/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/default/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/default/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/rules.mk Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update rules.mk * Update config.h * Update keymap.c * Update keyboards/nopunin10did/railroad/railroad.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update railroad.h * Update keyboards/nopunin10did/railroad/railroad.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/default/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/rules.mk Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/nopunin10did/railroad/config.h Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/nopunin10did/railroad/readme.md Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Updates from peer review to correct render * Update keyboards/nopunin10did/railroad/info.json Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/nopunin10did/railroad/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/nopunin10did/railroad/info.json Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Relocate most files inside rev0 Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Ryan <fauxpark@gmail.com>
ringmaster
pushed a commit
to ringmaster/qmk_firmware
that referenced
this pull request
Nov 5, 2020
* Add The Railroad keyboard, rev 0 * Update keyboards/nopunin10did/railroad/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update config.h * Update keyboards/nopunin10did/railroad/rules.mk Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/nopunin10did/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/nopunin10did/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/nopunin10did/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/default/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/default/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/rules.mk Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update rules.mk * Update config.h * Update keymap.c * Update keyboards/nopunin10did/railroad/railroad.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update railroad.h * Update keyboards/nopunin10did/railroad/railroad.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/keymaps/default/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/nopunin10did/railroad/rules.mk Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/nopunin10did/railroad/config.h Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/nopunin10did/railroad/readme.md Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Updates from peer review to correct render * Update keyboards/nopunin10did/railroad/info.json Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/nopunin10did/railroad/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/nopunin10did/railroad/info.json Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Relocate most files inside rev0 Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add firmware code and documentation for The Railroad keyboard.
Types of Changes
Issues Fixed or Closed by This PR
Checklist