Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LeftyNumpad Keyboard #10500

Merged
merged 10 commits into from
Oct 7, 2020
Merged

LeftyNumpad Keyboard #10500

merged 10 commits into from
Oct 7, 2020

Conversation

tomswartz07
Copy link
Contributor

Description

Add new handwired keypad

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tomswartz07 tomswartz07 changed the title Clean LeftyNumpad code LeftyNumpad Keyboard Oct 1, 2020
@tomswartz07
Copy link
Contributor Author

Apologies for the noise on the PR, seems there was a minor conflict between how the tests ran and how the make process worked.

make worked fine, no issues, but the discrepancy between the layout was caught by the PR tests (yay PR tests!)

zvecr
zvecr requested changes Oct 1, 2020
View reviewed changes
keyboards/handwired/leftynumpad/lefty-numpad.json Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/leftynumpad.c Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@zvecr zvecr added the keyboard label Oct 1, 2020
@zvecr zvecr requested a review from a team October 1, 2020 22:32
tomswartz07 and others added 4 commits October 2, 2020 15:46
@tomswartz07
Initial PR Feedback fixes
e8ac830
@tomswartz07 @zvecr
Update keyboards/handwired/leftynumpad/config.h
5838dd6 
Co-authored-by: Joel Challis <git@zvecr.com>
@tomswartz07 @zvecr
Update keyboards/handwired/leftynumpad/config.h
9c07a4b 
Co-authored-by: Joel Challis <git@zvecr.com>
@tomswartz07 @zvecr
Apply suggestions from code review
336968c 
Co-authored-by: Joel Challis <git@zvecr.com>
@tomswartz07 tomswartz07 requested review from zvecr and removed request for a team October 2, 2020 19:52
noroadsleft
noroadsleft requested changes Oct 3, 2020
View reviewed changes
keyboards/handwired/leftynumpad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/info.json Outdated Show resolved Hide resolved
keyboards/handwired/leftynumpad/info.json Outdated Show resolved Hide resolved
tomswartz07 and others added 2 commits October 4, 2020 14:32
@tomswartz07 @noroadsleft @fauxpark
Apply suggestions from code review
8a7ad1e 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@tomswartz07
Add fixes based on PR feedback
5e7eb84
@tomswartz07
Copy link
Contributor Author

Thanks all for the feedback. There were a lot of items here which I didn't consider and seemed to be glossed over in the PR guide.

If you feel it's appropriate, I would be more than happy to make a PR to those docs as well to fill out the documentation there.

@tomswartz07 @fauxpark
Update keyboards/handwired/leftynumpad/readme.md
f79b62a 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna merged commit ee6c86d into qmk:master Oct 7, 2020
barrettclark pushed a commit to barrettclark/qmk_firmware that referenced this pull request Oct 8, 2020
Merge remote-tracking branch 'upstream/master' into master
5a529c4 
* upstream/master: (81 commits)
  [Keyboard] New keyboard - eiri (qmk#10529)
  [Keymap] Add niu mini dye sub keymap (qmk#10525)
  Clean ChibiOS platform files (qmk#10505)
  [Keyboard] LeftyNumpad Keyboard (qmk#10500)
  [Keyboard] add maja capslock indicator (qmk#10151)
  Fix issue introduced by PR#10404 (qmk#10559)
  Docs: fix udev rules
  [CLI] Add c2json (qmk#8817)
  Improve LAYOUT macro searching (qmk#9530)
  CLI: update subcommands to use return instead of exit() (qmk#10323)
  Fixes small typo in docs (qmk#10515)
  Update personal keymap for Let's Split keyboard. (qmk#10536)
  [Keymap] Move my custom functions and keymaps to userspace (qmk#10502)
  [Keyboard] add support for ymd75 rev3 (qmk#10483)
  [Keyboard] Add soy20 PCB (qmk#10440)
  Fix for MIDI sustain effect issue (qmk#10361)
  format code according to conventions [skip ci]
  [Keyboard] Add Yugo-M Controller (qmk#10389)
  [Keymap] Add onekey keymap for OLED testing (qmk#10380)
  [Keymap] Add winterNebs keymaps  (qmk#10328)
  ...
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@tomswartz07 @zvecr
@noroadsleft @fauxpark
[Keyboard] LeftyNumpad Keyboard (qmk#10500)
167f3c4 
* Clean LeftyNumpad code

* Fix typo in recently renamed file

* Fix issues with keymap layout

* Initial PR Feedback fixes

* Update keyboards/handwired/leftynumpad/config.h

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/handwired/leftynumpad/config.h

Co-authored-by: Joel Challis <git@zvecr.com>

* Apply suggestions from code review

Co-authored-by: Joel Challis <git@zvecr.com>

* Apply suggestions from code review

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Add fixes based on PR feedback

* Update keyboards/handwired/leftynumpad/readme.md

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
@tomswartz07 @zvecr
@noroadsleft @fauxpark
[Keyboard] LeftyNumpad Keyboard (qmk#10500)
875be32 
* Clean LeftyNumpad code

* Fix typo in recently renamed file

* Fix issues with keymap layout

* Initial PR Feedback fixes

* Update keyboards/handwired/leftynumpad/config.h

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/handwired/leftynumpad/config.h

Co-authored-by: Joel Challis <git@zvecr.com>

* Apply suggestions from code review

Co-authored-by: Joel Challis <git@zvecr.com>

* Apply suggestions from code review

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Add fixes based on PR feedback

* Update keyboards/handwired/leftynumpad/readme.md

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@Erovia Erovia Awaiting requested review from Erovia

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomswartz07 @drashna @Erovia @fauxpark @zvecr @noroadsleft