Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update info.json for Slice RGB #10514

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Update info.json for Slice RGB #10514

merged 1 commit into from
Oct 2, 2020

Conversation

noroadsleft
Copy link
Member

Description

  • add data for LAYOUT_all macro
  • correct some rounding errors
  • make the indentation consistent
  • remove trailing whitespace

@2Moons-JP, when you add a layout macro to a keyboard's header file, the layout data for that macro needs to be added to the info.json file.

Layout Data:
image

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
Update info.json for Slice RGB
f78f736 
- add data for LAYOUT_all macro
- correct some rounding errors
- make the indentation consistent
- remove trailing whitespace
@noroadsleft noroadsleft requested a review from a team October 2, 2020 17:32
@zvecr zvecr merged commit eb4cf71 into qmk:master Oct 2, 2020
@noroadsleft noroadsleft deleted the cf/slice1rgb branch October 2, 2020 20:54
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@noroadsleft @rgoulter
Update info.json for Slice RGB (qmk#10514)
e37058c 
- add data for LAYOUT_all macro
- correct some rounding errors
- make the indentation consistent
- remove trailing whitespace
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@noroadsleft
Update info.json for Slice RGB (qmk#10514)
df9e747 
- add data for LAYOUT_all macro
- correct some rounding errors
- make the indentation consistent
- remove trailing whitespace
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
@noroadsleft
Update info.json for Slice RGB (qmk#10514)
fab85eb 
- add data for LAYOUT_all macro
- correct some rounding errors
- make the indentation consistent
- remove trailing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @fauxpark @zvecr