Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in the CLI's rules.mk parsing code #10522

Closed
wants to merge 1 commit into from
Closed

Fix a bug in the CLI's rules.mk parsing code #10522

wants to merge 1 commit into from

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented Oct 3, 2020

DEFAULT_FOLDER could cause unexpected behaviour when the user specified
the full revision of the board.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia
Fix a bug in the CLI's rules.mk parsing code
be0186c 
DEFAULT_FOLDER could cause unexpected behaviour when the user specified
the full revision of the board.
@Erovia Erovia added bug cli qmk cli command python labels Oct 3, 2020
@Erovia Erovia requested review from skullydazed and a team October 3, 2020 13:22
@fauxpark
Copy link
Member

fauxpark commented Oct 3, 2020

Does this intersect with #9530 at all?

@Erovia
Copy link
Member Author

Erovia commented Oct 3, 2020

Big oof, from a quick glance, it fixes the same bug.

@fauxpark
Copy link
Member

@Erovia is this still needed now that the above PR has gone in?

@Erovia Erovia closed this Oct 23, 2020
@Erovia
Copy link
Member Author

Erovia commented Oct 23, 2020

Nope.

@Erovia Erovia deleted the cli/rulesmk_fix branch October 23, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed Awaiting requested review from skullydazed

Assignees
No one assigned
Labels
bug cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Erovia @fauxpark