Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard]Add X-Bows Nature Keyboard #10869

Merged
merged 20 commits into from
Nov 19, 2020
Merged

[Keyboard]Add X-Bows Nature Keyboard #10869

merged 20 commits into from
Nov 19, 2020

Conversation

XBowsTech
Copy link
Contributor

Description

Add support for X-Bows Nature Ergonomic Mechanical Keyboard.
Nature, A 86 Keys Ergonomic Mechanical Keyboard with RGB backlight.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@XBowsTech
[Keyboard]Add X-Bows Nature Keyboard
a12edc5 
Add support for X-Bows Nature Ergonomic Mechanical Keyboard.
Nature, A 86 Keys Ergonomic Mechanical Keyboard with RGB backlight.
@XBowsTech
Copy link
Contributor Author

XBowsTech commented Nov 6, 2020 •
edited
Loading

I don't know why the PR check failed.Can someone tell me why?
By the way, do I need to change anything?

zvecr
zvecr requested changes Nov 6, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the build is failing due to you providing an invalid json file.

@zvecr zvecr added the pr_checklist_pending Needs changes as per the PR checklist label Nov 6, 2020
@XBowsTech
Copy link
Contributor Author

One of the build is failing due to you providing an invalid json file.

Thank you very much! Under your reminder, I have found out the mistake and fixed it.

@XBowsTech
Copy link
Contributor Author

One of the build is failing due to you providing an invalid json file.

Are there any other problems with these documents? Can it be passed through?

@XBowsTech XBowsTech requested a review from zvecr November 11, 2020 15:56
drashna
drashna requested changes Nov 16, 2020
View reviewed changes
keyboards/xbows/nature/config.h Outdated Show resolved Hide resolved
keyboards/xbows/nature/nature.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team November 16, 2020 00:48
@XBowsTech XBowsTech requested review from drashna and removed request for a team November 16, 2020 02:44
@drashna drashna requested a review from a team November 17, 2020 05:21
XBowsTech and others added 2 commits November 17, 2020 17:42
@XBowsTech @drashna
Update keyboards/xbows/nature/nature.c
2a18f4c 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@XBowsTech @drashna
Update keyboards/xbows/nature/config.h
02a8972 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Erovia
Erovia requested changes Nov 17, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and test the keymap and matrix modifications with an actual keyboard.
Such matrix wiring "quirks" should be masked from the users by the layout macro.

keyboards/xbows/nature/readme.md Show resolved Hide resolved
keyboards/xbows/nature/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/xbows/nature/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/xbows/nature/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/xbows/nature/nature.h Outdated Show resolved Hide resolved
XBowsTech and others added 8 commits November 18, 2020 15:30
@XBowsTech
Update nature.c
fecd539
@XBowsTech
Update nature.c
718d179
@XBowsTech @Erovia
Update keyboards/xbows/nature/keymaps/default/keymap.c
73783d0 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@XBowsTech @Erovia
Update keyboards/xbows/nature/keymaps/default/keymap.c
95a46b6 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@XBowsTech @Erovia
Update keyboards/xbows/nature/keymaps/default/keymap.c
1262b7d 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@XBowsTech @Erovia
Update keyboards/xbows/nature/nature.h
8500799 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@XBowsTech
Update keymap.c
8ff15c0
@XBowsTech
Update readme.md
6b0dc2d
@XBowsTech XBowsTech requested a review from Erovia November 18, 2020 08:46
fauxpark
fauxpark requested changes Nov 18, 2020
View reviewed changes
keyboards/xbows/nature/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/xbows/nature/readme.md Outdated Show resolved Hide resolved
keyboards/xbows/nature/readme.md Show resolved Hide resolved
keyboards/xbows/nature/rules.mk Show resolved Hide resolved
keyboards/xbows/nature/rules.mk Outdated Show resolved Hide resolved
XBowsTech and others added 2 commits November 18, 2020 17:33
@XBowsTech @fauxpark
Update keyboards/xbows/nature/keymaps/default/keymap.c
88b040f 
Co-authored-by: Ryan <fauxpark@gmail.com>
@XBowsTech @fauxpark
Update keyboards/xbows/nature/readme.md
9b22969 
Co-authored-by: Ryan <fauxpark@gmail.com>
XBowsTech and others added 4 commits November 18, 2020 17:34
@XBowsTech @fauxpark
Update keyboards/xbows/nature/rules.mk
720834b 
Co-authored-by: Ryan <fauxpark@gmail.com>
@XBowsTech @fauxpark
Update keyboards/xbows/nature/rules.mk
7a442f9 
Co-authored-by: Ryan <fauxpark@gmail.com>
@XBowsTech @fauxpark
Update keyboards/xbows/nature/readme.md
61b1f53 
Co-authored-by: Ryan <fauxpark@gmail.com>
@XBowsTech
Update rules.mk
94ef32e
fauxpark
fauxpark requested changes Nov 18, 2020
View reviewed changes
keyboards/xbows/nature/rules.mk Outdated Show resolved Hide resolved
@XBowsTech @fauxpark
Update keyboards/xbows/nature/rules.mk
6e01850 
Co-authored-by: Ryan <fauxpark@gmail.com>
@XBowsTech XBowsTech requested a review from fauxpark November 19, 2020 05:37
@Erovia Erovia merged commit 9454f98 into qmk:master Nov 19, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@XBowsTech @drashna
@Erovia @fauxpark @xgnxs
[Keyboard]Add X-Bows Nature Keyboard (qmk#10869)
aaa6dec 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard keymap pr_checklist_pending Needs changes as per the PR checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XBowsTech @drashna @Erovia @fauxpark @zvecr